All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicolinc@nvidia.com>
To: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
Cc: "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"Kurmi, Suresh Kumar" <suresh.kumar.kurmi@intel.com>,
	"Saarinen, Jani" <jani.saarinen@intel.com>,
	"jgg@nvidia.com" <jgg@nvidia.com>
Subject: Re: Regression on linux-next (next-20250321)
Date: Wed, 26 Mar 2025 13:43:32 -0700	[thread overview]
Message-ID: <Z+Rm9LweNAtQBrmD@nvidia.com> (raw)
In-Reply-To: <SJ1PR11MB61292F9467353BA9FBB8F4B6B9A62@SJ1PR11MB6129.namprd11.prod.outlook.com>

Hi Chaitanya,

On Wed, Mar 26, 2025 at 08:31:15AM +0000, Borah, Chaitanya Kumar wrote:
> > > `````````````````````````````````````````````````````````````````````````````````
> > > <4>[    0.226495] Unpatched return thunk in use. This should not happen!
> > > <4>[    0.226502] WARNING: CPU: 0 PID: 1 at
> > arch/x86/kernel/cpu/bugs.c:3107 __warn_thunk+0x62/0x70
> > 
> > Hmm....I wonder why x86 can be affected...
> > 
> > The only four callers of iommu_dma_prepare_msi() are ARM platforms.
[...]
> > > Details log can be found in [3].
> > 
> > And I can't see something obvious from the log..
> > 
> > Would you please give the git-diff a try (drivers/iommu/iommu.c)?
> > https://lore.kernel.org/linux-iommu/Z+Itnw4ys6dmDsc+@nvidia.com/
> > 
> > If this doesn't help, would you please give this a try?
> > https://lore.kernel.org/linux-iommu/20250324170743.GA1339275@ax162/
> > 
> 
> Thank you, Nicolin, for your reply. Unfortunately, these changes
> does not solve the issue. (applied individually and together)

Would you please try the latest linux-next (next-20250326) and see
if the issue still occurs?

If it does occur with next-20250326, would you please try reverting
06d54f00f3f5a on top of the tree rather than bisect?
 "06d54f00f3f5 iommu: Drop sw_msi from iommu_domain"

It still feels odd to me and Jason that this change would break x86.
So, we want to confirm that this is really the culprit.

Also, I think your platform doesn't set CONFIG_IRQ_MSI_IOMMU, would
you please check you .config file and confirm?

Thanks
Nicolin

  reply	other threads:[~2025-03-26 20:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25  5:39 Regression on linux-next (next-20250321) Borah, Chaitanya Kumar
2025-03-25  7:40 ` Nicolin Chen
2025-03-25 13:43   ` Jason Gunthorpe
2025-03-27  5:39     ` Josh Poimboeuf
2025-03-27  8:09       ` Borah, Chaitanya Kumar
2025-03-26  8:31   ` Borah, Chaitanya Kumar
2025-03-26 20:43     ` Nicolin Chen [this message]
2025-03-27  8:46       ` Borah, Chaitanya Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z+Rm9LweNAtQBrmD@nvidia.com \
    --to=nicolinc@nvidia.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=iommu@lists.linux.dev \
    --cc=jani.saarinen@intel.com \
    --cc=jgg@nvidia.com \
    --cc=suresh.kumar.kurmi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.