From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24A60C3600B for ; Thu, 27 Mar 2025 09:33:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1txjc3-00050F-4x; Thu, 27 Mar 2025 05:33:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txjc0-0004x1-Ob for qemu-devel@nongnu.org; Thu, 27 Mar 2025 05:33:20 -0400 Received: from ssh.movementarian.org ([139.162.205.133] helo=movementarian.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1txjby-00083b-BR for qemu-devel@nongnu.org; Thu, 27 Mar 2025 05:33:20 -0400 Received: from movement by movementarian.org with local (Exim 4.95) (envelope-from ) id 1txjbw-003mXL-LH; Thu, 27 Mar 2025 09:33:16 +0000 Date: Thu, 27 Mar 2025 09:33:16 +0000 From: John Levon To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: qemu-devel@nongnu.org, Alex Williamson , Avihai Horon , Eric Auger , Zhenzhong Duan , Joao Martins Subject: Re: [PATCH for-10.1 v2 25/37] vfio: Move vfio_reset_handler() into device.c Message-ID: References: <20250326075122.1299361-1-clg@redhat.com> <20250326075122.1299361-26-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250326075122.1299361-26-clg@redhat.com> X-Url: http://www.movementarian.org/ Received-SPF: pass client-ip=139.162.205.133; envelope-from=movement@movementarian.org; helo=movementarian.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Mar 26, 2025 at 08:51:10AM +0100, Cédric Le Goater wrote: > Pass-through devices of a VM are not necessarily in the same group and > all groups/address_spaces need to be scanned when the machine is > reset. Commit f16f39c3fc97 ("Implement PCI hot reset") introduced a VM > reset handler for this purpose. Move it under device.c > > Also reintroduce the comment which explained the context and was lost > along the way. > > Signed-off-by: Cédric Le Goater Reviewed-by: John Levon regards john