From: Baoquan He <bhe@redhat.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev
Subject: Re: [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked()
Date: Tue, 1 Apr 2025 23:29:14 +0800 [thread overview]
Message-ID: <Z+wGSs6xo5Q3CnLF@MiWiFi-R3L-srv> (raw)
In-Reply-To: <Z-vvdrpr-MnkpH7d@localhost.localdomain>
On 04/01/25 at 03:51pm, Oscar Salvador wrote:
> On Mon, Mar 31, 2025 at 04:13:23PM +0800, Baoquan He wrote:
> > Since commit f0818f472d8d ("mm: gup: add get_user_pages_locked
> > and get_user_pages_unlocked"), get_user_pages() doesn't need to have
> > mmap_lock held anymore. It calls __get_user_pages_locked() which
> > can acquire and drop the mmap_lock internaly.
> >
> > Hence remove the incorrect code comments now.
>
> Uhm, I think this one should be dropped according to
Yeah, this v2 series was sent earlier than your comment in v1. Sorry
about the mess.
>
> https://lore.kernel.org/linux-mm/20250330121718.175815-4-bhe@redhat.com/T/#m1aa161016ab98a6d85bcb657a729e01cb98763ec
>
> ?
>
>
> --
> Oscar Salvador
> SUSE Labs
>
next prev parent reply other threads:[~2025-04-01 15:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 8:13 [PATCH v2 0/7] mm/gup: Minor fix, cleanup and improvements Baoquan He
2025-03-31 8:13 ` [PATCH v2 1/7] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() Baoquan He
2025-04-01 8:10 ` David Hildenbrand
2025-04-01 14:00 ` Oscar Salvador
2025-04-01 14:12 ` Baoquan He
2025-04-01 14:11 ` Baoquan He
2025-03-31 8:13 ` [PATCH v2 2/7] mm/gup: check if both GUP_GET and GUP_PIN are set in __get_user_pages() earlier Baoquan He
2025-04-01 8:02 ` David Hildenbrand
2025-04-01 14:34 ` Baoquan He
2025-04-01 14:37 ` David Hildenbrand
2025-04-02 1:26 ` Baoquan He
2025-03-31 8:13 ` [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked() Baoquan He
2025-04-01 8:14 ` David Hildenbrand
2025-04-01 14:36 ` Baoquan He
2025-04-01 13:51 ` Oscar Salvador
2025-04-01 15:29 ` Baoquan He [this message]
2025-03-31 8:13 ` [PATCH v2 4/7] mm/gup: remove gup_fast_pgd_leaf() and clean up the relevant codes Baoquan He
2025-04-01 8:19 ` David Hildenbrand
2025-04-01 14:11 ` Oscar Salvador
2025-03-31 8:13 ` [PATCH v2 5/7] x86/mm: remove pgd_leaf definition in arch Baoquan He
2025-03-31 10:25 ` [tip: x86/mm] x86/mm: Simplify the pgd_leaf() and p4d_leaf() checks a bit tip-bot2 for Baoquan He
2025-03-31 10:26 ` [tip: x86/mm] x86/mm: Remove the arch-specific pgd_leaf() definition tip-bot2 for Baoquan He
2025-04-01 8:21 ` [PATCH v2 5/7] x86/mm: remove pgd_leaf definition in arch David Hildenbrand
2025-04-01 14:03 ` Oscar Salvador
2025-04-02 3:39 ` Baoquan He
2025-04-01 20:53 ` [tip: x86/mm] x86/mm: Simplify the pgd_leaf() and p4d_leaf() checks a bit tip-bot2 for Baoquan He
2025-04-01 20:53 ` [tip: x86/mm] x86/mm: Remove the arch-specific pgd_leaf() definition tip-bot2 for Baoquan He
2025-04-01 21:03 ` [tip: x86/mm] x86/mm: Simplify the pgd_leaf() and p4d_leaf() checks a bit tip-bot2 for Baoquan He
2025-03-31 8:13 ` [PATCH v2 6/7] x86/mm: remove p4d_leaf definition Baoquan He
2025-03-31 9:57 ` Ingo Molnar
2025-03-31 14:20 ` Baoquan He
2025-04-01 7:20 ` Ingo Molnar
2025-04-03 13:44 ` Baoquan He
2025-03-31 10:25 ` [tip: x86/mm] x86/mm: Remove the arch-specific p4d_leaf() definition tip-bot2 for Baoquan He
2025-04-01 14:05 ` [PATCH v2 6/7] x86/mm: remove p4d_leaf definition Oscar Salvador
2025-04-01 20:53 ` [tip: x86/mm] x86/mm: Remove the arch-specific p4d_leaf() definition tip-bot2 for Baoquan He
2025-04-01 21:03 ` tip-bot2 for Baoquan He
2025-03-31 8:13 ` [PATCH v2 7/7] mm/pgtable: remove unneeded pgd_devmap() Baoquan He
2025-04-01 8:21 ` David Hildenbrand
2025-04-02 3:33 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z+wGSs6xo5Q3CnLF@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.