From: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
To: Songtang Liu <liusongtang@bytedance.com>
Cc: akpm@linux-foundation.org, ying.huang@linux.alibaba.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
zhengqi.arch@bytedance.com, songmuchun@bytedance.com
Subject: Re: [PATCH] mm: page_alloc: Remove redundant READ_ONCE
Date: Wed, 2 Apr 2025 12:01:52 -0700 [thread overview]
Message-ID: <Z-2JoJWjGuqWCsdu@fedora> (raw)
In-Reply-To: <CAA=HWd1kn01ym8YuVFuAqK2Ggq3itEGkqX8T6eCXs_C7tiv-Jw@mail.gmail.com>
On Wed, Apr 02, 2025 at 03:41:16AM -0400, Songtang Liu wrote:
> In the current code, batch is a local variable, and it cannot be
> concurrently modified. It's unnecessary to use READ_ONCE here,
> so remove it.
>
> Fixes: 51a755c56dc0 ("mm: tune PCP high automatically")
> Signed-off-by: Songtang Liu <liusongtang@bytedance.com>
Reviewed-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
prev parent reply other threads:[~2025-04-02 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 7:41 [PATCH] mm: page_alloc: Remove redundant READ_ONCE Songtang Liu
2025-04-02 7:59 ` Qi Zheng
2025-04-02 8:30 ` Huang, Ying
2025-04-02 8:53 ` Anshuman Khandual
2025-04-02 9:27 ` Gupta, Pankaj
2025-04-02 9:32 ` Oscar Salvador
2025-04-02 19:01 ` Vishal Moola (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-2JoJWjGuqWCsdu@fedora \
--to=vishal.moola@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liusongtang@bytedance.com \
--cc=songmuchun@bytedance.com \
--cc=ying.huang@linux.alibaba.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.