All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, amit@kernel.org,
	kvm@vger.kernel.org, amit.shah@amd.com, thomas.lendacky@amd.com,
	bp@alien8.de, tglx@linutronix.de, peterz@infradead.org,
	pawan.kumar.gupta@linux.intel.com, corbet@lwn.net,
	mingo@redhat.com, dave.hansen@linux.intel.com, hpa@zytor.com,
	seanjc@google.com, pbonzini@redhat.com,
	daniel.sneddon@linux.intel.com, kai.huang@intel.com,
	sandipan.das@amd.com, boris.ostrovsky@oracle.com,
	Babu.Moger@amd.com, david.kaplan@amd.com, dwmw@amazon.co.uk,
	andrew.cooper3@citrix.com
Subject: Re: [PATCH v3 1/6] x86/bugs: Rename entry_ibpb()
Date: Wed, 2 Apr 2025 21:37:07 +0200	[thread overview]
Message-ID: <Z-2R4_xF8H_DlEqm@gmail.com> (raw)
In-Reply-To: <a3ce1558b68a64f52ea56000f2bbdfd6e7799258.1743617897.git.jpoimboe@kernel.org>


* Josh Poimboeuf <jpoimboe@kernel.org> wrote:

> There's nothing entry-specific about entry_ibpb().  In preparation for
> calling it from elsewhere, rename it to __write_ibpb().

Minor Git-log hygienic request, could you please mention in such 
patches what the *new* name is?

This title is annoyingly passive-aggressive:

  x86/bugs: Rename entry_ibpb()

Let's make it:

  x86/bugs: Rename entry_ibpb() to write_ibpb()

... or so. Because the new name is infinitely more important going 
forward than the old name is ever going to be. :-)

Thanks,

	Ingo

  parent reply	other threads:[~2025-04-02 19:37 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02 18:19 [PATCH v3 0/6] x86/bugs: RSB mitigation fixes and documentation Josh Poimboeuf
2025-04-02 18:19 ` [PATCH v3 1/6] x86/bugs: Rename entry_ibpb() Josh Poimboeuf
2025-04-02 18:29   ` Borislav Petkov
2025-04-02 18:44     ` Josh Poimboeuf
2025-04-02 18:48       ` Borislav Petkov
2025-04-02 19:37   ` Ingo Molnar [this message]
2025-04-03  0:34     ` Josh Poimboeuf
2025-04-02 18:19 ` [PATCH v3 2/6] x86/bugs: Use SBPB in __write_ibpb() if applicable Josh Poimboeuf
2025-04-02 20:41   ` Tom Lendacky
2025-04-03  2:12     ` Josh Poimboeuf
2025-04-02 21:04   ` Jim Mattson
2025-04-03  2:17     ` Josh Poimboeuf
2025-04-09 18:07       ` Jim Mattson
2025-04-09 18:29         ` Kaplan, David
2025-04-09 18:46           ` Jim Mattson
2025-04-02 18:19 ` [PATCH v3 3/6] x86/bugs: Fix RSB clearing in indirect_branch_prediction_barrier() Josh Poimboeuf
2025-04-04 14:45   ` Nikolay Borisov
2025-04-04 15:17     ` Josh Poimboeuf
2025-04-04 22:56       ` Nikolay Borisov
2025-04-05  0:56         ` Josh Poimboeuf
2025-04-08  7:15           ` Nikolay Borisov
2025-04-02 18:19 ` [PATCH v3 4/6] x86/bugs: Don't fill RSB on VMEXIT with eIBRS+retpoline Josh Poimboeuf
2025-04-08 13:50   ` Nikolay Borisov
2025-04-02 18:19 ` [PATCH v3 5/6] x86/bugs: Don't fill RSB on context switch with eIBRS Josh Poimboeuf
2025-04-08 13:51   ` Nikolay Borisov
2025-04-02 18:19 ` [PATCH v3 6/6] x86/bugs: Add RSB mitigation document Josh Poimboeuf
2025-04-02 19:58   ` Ingo Molnar
2025-04-03  0:38     ` Josh Poimboeuf
2025-04-03  2:57   ` Bagas Sanjaya
2025-04-03  7:48     ` Josh Poimboeuf
2025-04-04  2:39   ` Andrew Cooper
2025-04-04 19:30     ` Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-2R4_xF8H_DlEqm@gmail.com \
    --to=mingo@kernel.org \
    --cc=Babu.Moger@amd.com \
    --cc=amit.shah@amd.com \
    --cc=amit@kernel.org \
    --cc=andrew.cooper3@citrix.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=daniel.sneddon@linux.intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=david.kaplan@amd.com \
    --cc=dwmw@amazon.co.uk \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@kernel.org \
    --cc=kai.huang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=sandipan.das@amd.com \
    --cc=seanjc@google.com \
    --cc=tglx@linutronix.de \
    --cc=thomas.lendacky@amd.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.