All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 02/11] ci: increase timeout for hw tests
Date: Thu, 3 Apr 2025 14:25:32 +0200	[thread overview]
Message-ID: <Z-5-PBcbtUOCSAiv@mail-itl> (raw)
In-Reply-To: <9e4660fc-b78f-4323-8a1b-aca3d410edd3@suse.com>

[-- Attachment #1: Type: text/plain, Size: 1787 bytes --]

On Thu, Apr 03, 2025 at 01:32:38PM +0200, Jan Beulich wrote:
> On 03.04.2025 13:04, Marek Marczykowski-Górecki wrote:
> > It appears as sometimes it takes more time for Xen even start booting,
> > mostly due to firmware and fetching large boot files by grub. In some
> > jobs the current timeout is pretty close to the actual time needed, and
> > sometimes (rarely for now) test fails due to timeout expiring in the
> > middle of dom0 booting. This will be happening more often if the
> > initramfs will grow (and with more complex tests).
> 
> With that, ...
> 
> > This has been observed on some dom0pvh-hvm jobs, at least on runners hw3
> > and hw11.
> > 
> > Increase the timeout by yet another 60s (up to 180s now).
> 
> ... is this little a bump going to be sufficient? How about moving straight
> to 5min?

I don't like this, as many (most) actual failures are visible as timeout
(for example panic that prevents reaching Alpine prompt). One
improvement I can see is splitting this into two separate timeouts: one
before seeing the first line from Xen and then the second one for
reaching Alpine login prompt. The first one can be longer as its mostly
about firmware+fetching boot files and shouldn't hit on crashes (unless
a crash happen before printing anything on the console - but those are
rare).

> As to observed failing jobs - the PV Dom0 boot failure seen today looks to
> also be due to too short a timeout.

As responded on Matrix, I'm not so sure, there is over 1m wait after
"Built 1 zonelists, mobility grouping on.  Total pages: 8228487" line
from dom0 (or a bit later, due to buffering by sed), while in successful
test next lines follow instantaneously.

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2025-04-03 12:26 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 11:04 [PATCH v1 00/11] Several CI cleanups and improvements, plus yet another new runner Marek Marczykowski-Górecki
2025-04-03 11:04 ` [PATCH v1 01/11] ci: prevent grub unpacking initramfs Marek Marczykowski-Górecki
2025-04-03 11:29   ` Jan Beulich
2025-04-03 11:36     ` Marek Marczykowski-Górecki
2025-04-03 11:39     ` Andrew Cooper
2025-04-03 12:03       ` Jan Beulich
2025-04-05  0:28       ` Marek Marczykowski-Górecki
2025-04-04  0:16   ` Stefano Stabellini
2025-04-03 11:04 ` [PATCH v1 02/11] ci: increase timeout for hw tests Marek Marczykowski-Górecki
2025-04-03 11:32   ` Jan Beulich
2025-04-03 12:25     ` Marek Marczykowski-Górecki [this message]
2025-04-04  0:21       ` Stefano Stabellini
2025-04-04  0:35         ` Marek Marczykowski-Górecki
2025-04-03 11:04 ` [PATCH v1 03/11] ci: enable XHCI console in Xen debug build on Alpine Marek Marczykowski-Górecki
2025-04-04  0:22   ` Stefano Stabellini
2025-04-03 11:04 ` [PATCH v1 04/11] ci: include domU kernel messages in the console output log Marek Marczykowski-Górecki
2025-04-04  0:23   ` Stefano Stabellini
2025-04-03 11:04 ` [PATCH v1 05/11] ci: increase verbosity of starting a domain Marek Marczykowski-Górecki
2025-04-04  0:33   ` Stefano Stabellini
2025-04-03 11:04 ` [PATCH v1 06/11] ci: consistently use DOCKER_CMD in makefiles Marek Marczykowski-Górecki
2025-04-04  0:35   ` Stefano Stabellini
2025-04-03 11:04 ` [PATCH v1 07/11] ci: wait for the network interface in PCI passthrough tests Marek Marczykowski-Górecki
2025-04-04  0:36   ` Stefano Stabellini
2025-04-03 11:04 ` [PATCH v1 09/11] ci: adjust resolving network interface into PCI device Marek Marczykowski-Górecki
2025-04-04  0:45   ` Stefano Stabellini
2025-04-03 11:04 ` [PATCH v1 10/11] ci: add AMD Zen 4 HW runner Marek Marczykowski-Górecki
2025-04-04  0:46   ` Stefano Stabellini
2025-04-03 11:04 ` [PATCH v1 11/11] [DO NOT MERGE] container Marek Marczykowski-Górecki
     [not found] ` <612750de76202364b749bda6cdd30c1daa81f79d.1743678257.git-series.marmarek@invisiblethingslab.com>
     [not found]   ` <alpine.DEB.2.22.394.2504031737290.3529306@ubuntu-linux-20-04-desktop>
2025-04-04 11:13     ` [PATCH v1 08/11] ci: switch test kernel from 6.1.19 to 6.12.21 Marek Marczykowski-Górecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-5-PBcbtUOCSAiv@mail-itl \
    --to=marmarek@invisiblethingslab.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=jbeulich@suse.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.