From: Danilo Krummrich <dakr@kernel.org>
To: phasta@kernel.org
Cc: "Christian König" <christian.koenig@amd.com>,
"Lyude Paul" <lyude@redhat.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linaro-mm-sig@lists.linaro.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] drm/nouveau: Prevent signalled fences in pending list
Date: Thu, 3 Apr 2025 15:15:25 +0200 [thread overview]
Message-ID: <Z-6J7bngU2JtfMMN@pollux> (raw)
In-Reply-To: <2558c9cf0cf28867238eb21950ce2a3f862c15c3.camel@mailbox.org>
On Thu, Apr 03, 2025 at 02:58:13PM +0200, Philipp Stanner wrote:
> On Thu, 2025-04-03 at 14:08 +0200, Christian König wrote:
> > Am 03.04.25 um 12:13 schrieb Philipp Stanner:
>
> > BTW: nouveau_fence_no_signaling() looks completely broken as well. It
> > calls nouveau_fence_is_signaled() and then list_del() on the fence
> > head.
>
> I can assure you that a great many things in Nouveau look completely
> broken.
>
> The question for us is always the cost-benefit-ratio when fixing bugs.
> There are fixes that solve the bug with reasonable effort, and there
> are great reworks towards an ideal state.
That's just an additional thing that Christian noticed. It isn't really directly
related to what you want to fix with your patch.
I think the function can simply be dropped.
next prev parent reply other threads:[~2025-04-03 13:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 10:13 [PATCH v2] drm/nouveau: Prevent signalled fences in pending list Philipp Stanner
2025-04-03 10:17 ` Philipp Stanner
2025-04-03 10:25 ` Danilo Krummrich
2025-04-03 12:22 ` Christian König
2025-04-03 12:41 ` Danilo Krummrich
2025-04-03 12:08 ` Christian König
2025-04-03 12:31 ` Danilo Krummrich
2025-04-03 12:58 ` Philipp Stanner
2025-04-03 13:10 ` Christian König
2025-04-03 14:40 ` Philipp Stanner
2025-04-04 14:14 ` Christian König
2025-04-03 13:15 ` Danilo Krummrich [this message]
2025-04-03 13:20 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-6J7bngU2JtfMMN@pollux \
--to=dakr@kernel.org \
--cc=airlied@gmail.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lyude@redhat.com \
--cc=nouveau@lists.freedesktop.org \
--cc=phasta@kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.