All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Raag Jadav <raag.jadav@intel.com>,
	david.m.ertman@intel.com, ira.weiny@intel.com, lee@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] mfd: core: Support auxiliary device
Date: Thu, 3 Apr 2025 17:19:22 +0300	[thread overview]
Message-ID: <Z-6Y6lbLSbe46-uQ@smile.fi.intel.com> (raw)
In-Reply-To: <Z-6YU24dhxF5PRaw@smile.fi.intel.com>

On Thu, Apr 03, 2025 at 05:16:51PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 03, 2025 at 03:02:47PM +0100, Greg KH wrote:
> > On Thu, Apr 03, 2025 at 04:30:53PM +0530, Raag Jadav wrote:

...

> > > 2. Should we allow auxiliary drivers to manage their own resources
> > >    (MEM, IO, IRQ etc)?
> > 
> > The resources are all shared by the "parent" device, that's what makes
> > aux drivers work, they need to handle this as there is no unique way to
> > carve up the resources here.
> > 
> > So I don't know how you would do this, sorry.
> 
> I think we should simply enforce the requirement that MFD on AUX bus must use
> regmap. This will solve the serialisation and common access to the resources.

That said, make an additional API call like

dev_mfd_add_aux_devices() which should enforce new infrastructure and convert
drivers one by one. Also with that you may add a warning to the existing (PCI)
drivers that are using old API

	if (dev_is_pci(parent))
		dev_warn(parent, "Uses old API, please switch to ...\n");

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2025-04-03 14:19 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-03 11:00 [PATCH v1] mfd: core: Support auxiliary device Raag Jadav
2025-04-03 14:02 ` Greg KH
2025-04-03 14:16   ` Andy Shevchenko
2025-04-03 14:19     ` Andy Shevchenko [this message]
2025-04-03 14:23       ` Greg KH
2025-04-03 14:26         ` Andy Shevchenko
2025-04-03 14:31           ` Raag Jadav
2025-04-04 11:36   ` Raag Jadav
2025-04-04 12:29     ` Andy Shevchenko
2025-04-04 12:35       ` Raag Jadav
2025-04-04 13:00         ` Andy Shevchenko
2025-04-04 13:39           ` Raag Jadav
2025-04-04 13:56             ` Andy Shevchenko
2025-04-04 14:47               ` Raag Jadav
2025-04-03 15:11 ` kernel test robot
2025-04-03 15:11 ` kernel test robot
2025-04-03 21:39 ` kernel test robot
2025-04-04 15:35 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-6Y6lbLSbe46-uQ@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=david.m.ertman@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ira.weiny@intel.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raag.jadav@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.