From: Ingo Molnar <mingo@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrii Nakryiko <andrii@kernel.org>,
linux-trace-kernel@vger.kernel.org, peterz@infradead.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com, mhocko@kernel.org, oleg@redhat.com,
brauner@kernel.org, glider@google.com, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com, akpm@linux-foundation.org
Subject: Re: [PATCH v2] exit: move and extend sched_process_exit() tracepoint
Date: Thu, 3 Apr 2025 17:11:57 +0200 [thread overview]
Message-ID: <Z-6lPadt51e7jcXd@gmail.com> (raw)
In-Reply-To: <20250403110615.7a51b793@gandalf.local.home>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 3 Apr 2025 15:54:22 +0200
> Ingo Molnar <mingo@kernel.org> wrote:
>
> > This feels really fragile, could you please at least add a comment
> > that points out that this is basically an extension of
> > sched_process_template, and that it should remain a subset of it,
> > or something to that end?
>
> Is there any dependency on this?
>
> I don't know of any other dependency to why this was a template other than
> to save memory.
Uhm, to state the obvious: to not replicate the same definitions over
and over again three times times, for 3 scheduler tracepoints that
share the record format?
Removing just a single sched_process_template use bloats the source and
adds in potential fragility:
2 files changed, 26 insertions(+), 4 deletions(-)
So my request is to please at least add a comment that points the
reader to the shared record format between sched_process_exit and the
other two tracepoints.
Thanks,
Ingo
next prev parent reply other threads:[~2025-04-03 15:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 18:09 [PATCH v2] exit: move and extend sched_process_exit() tracepoint Andrii Nakryiko
2025-04-02 18:36 ` Steven Rostedt
2025-04-02 19:29 ` Oleg Nesterov
2025-04-03 13:54 ` Ingo Molnar
2025-04-03 15:06 ` Steven Rostedt
2025-04-03 15:11 ` Ingo Molnar [this message]
2025-04-03 16:01 ` Andrii Nakryiko
2025-04-04 8:37 ` [tip: sched/core] sched/tracepoints: Move and extend the " tip-bot2 for Andrii Nakryiko
2025-04-04 15:49 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-6lPadt51e7jcXd@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=glider@google.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.