From: Raag Jadav <raag.jadav@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: mahesh@linux.ibm.com, oohall@gmail.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, lukas.wunner@intel.com
Subject: Re: [PATCH v1] PCI/AER: Avoid power state transition during system suspend
Date: Fri, 4 Apr 2025 08:26:41 +0300 [thread overview]
Message-ID: <Z-9tkV_iPntpROn-@black.fi.intel.com> (raw)
In-Reply-To: <CAJZ5v0gtUHbYPk-dFRwEZMnPv0gQG8+J+bwf8bahUskcDkw9HA@mail.gmail.com>
On Thu, Apr 03, 2025 at 08:35:45PM +0200, Rafael J. Wysocki wrote:
> On Thu, Apr 3, 2025 at 9:45 AM Raag Jadav <raag.jadav@intel.com> wrote:
> >
> > If an error is triggered while system suspend is in progress, any bus
> > level power state transition will result in unpredictable error handling.
> > Mark skip_bus_pm flag as true to avoid this.
>
> This needs to be synchronized with the skip_bus_pm clearing in pci_pm_suspend().
I'm wondering if we can have something like aer_in_progress flag
that we can use in PCI PM for this? ...
> Also, skip_bus_pm is only used in the _noirq phases, so if a driver
> calls pci_set_power_state() from its ->suspend() callback, this change
> won't help.
... and perhaps skip these if it is set?
Raag
next prev parent reply other threads:[~2025-04-04 5:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 7:44 [PATCH v1] PCI/AER: Avoid power state transition during system suspend Raag Jadav
2025-04-03 18:25 ` Raag Jadav
2025-04-03 18:35 ` Rafael J. Wysocki
2025-04-04 5:26 ` Raag Jadav [this message]
2025-04-04 3:08 ` Lukas Wunner
2025-04-04 5:22 ` Raag Jadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-9tkV_iPntpROn-@black.fi.intel.com \
--to=raag.jadav@intel.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas.wunner@intel.com \
--cc=mahesh@linux.ibm.com \
--cc=oohall@gmail.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.