From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5971C36002 for ; Mon, 24 Mar 2025 09:11:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1twdoz-0007rl-Ri; Mon, 24 Mar 2025 05:10:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twdoy-0007rX-Gl for qemu-devel@nongnu.org; Mon, 24 Mar 2025 05:10:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twdov-0006Iy-DL for qemu-devel@nongnu.org; Mon, 24 Mar 2025 05:10:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742807406; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n97f2z7th9agSHgtXKHlEs8mtFefbW/nzYFp4gk4Ejc=; b=YLK1C9ZS9q6FoqzygymQwWWqCDiXbjT7mk6jG9grzzHyjXBIFHSj6DFgaJXdHVUYSKplUV 8pYsrTg6ch9R2vZaG7X14IQJfAZU2zrVeR0DDXGMbFGsK7OQ9dqnZIHFiMxFYIgRc7W+Bi l11xlBIqZKKAE6ctHpb4fAY5AF8AmEA= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-297--Lh1UDl9OH2bAfi-8RtfWA-1; Mon, 24 Mar 2025 05:09:57 -0400 X-MC-Unique: -Lh1UDl9OH2bAfi-8RtfWA-1 X-Mimecast-MFC-AGG-ID: -Lh1UDl9OH2bAfi-8RtfWA_1742807396 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 26B79180035E; Mon, 24 Mar 2025 09:09:56 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.56]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9335B180B488; Mon, 24 Mar 2025 09:09:53 +0000 (UTC) Date: Mon, 24 Mar 2025 09:09:49 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Markus Armbruster , Paolo Bonzini , Pierrick Bouvier Subject: Re: [PATCH] system/vl: Tidy up break in QEMU_OPTION_machine case Message-ID: References: <20250323230006.36057-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250323230006.36057-1-philmd@linaro.org> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Mar 24, 2025 at 12:00:06AM +0100, Philippe Mathieu-Daudé wrote: > The break in the QEMU_OPTION_machine case is mis-placed. I think that's largely a bikeshed colouring question. If you look at other places in the outer switch using a block in the case, eg case FOO: { ..... } or case FOO: { ..... } they'll also have 'break' inside the '{}', so either this patch should change all, or change none. > > Not a big deal, since producing the same outcome, but > suspicious, so put it in the correct place. > > Signed-off-by: Philippe Mathieu-Daudé > --- > system/vl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/system/vl.c b/system/vl.c > index ec93988a03a..dbca9ebba4d 100644 > --- a/system/vl.c > +++ b/system/vl.c > @@ -3409,8 +3409,8 @@ void qemu_init(int argc, char **argv) > machine_help_func(machine_opts_dict); > exit(EXIT_SUCCESS); > } > - break; > } > + break; > case QEMU_OPTION_accel: > accel_opts = qemu_opts_parse_noisily(qemu_find_opts("accel"), > optarg, true); > -- > 2.47.1 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|