From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D0C3C36002 for ; Mon, 24 Mar 2025 09:13:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1twdrn-0000BH-BU; Mon, 24 Mar 2025 05:13:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twdrl-0000B4-Kr for qemu-devel@nongnu.org; Mon, 24 Mar 2025 05:13:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1twdrj-0006gZ-Eh for qemu-devel@nongnu.org; Mon, 24 Mar 2025 05:13:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742807582; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j9uih31wp+PNsX0v4ySpx7evQC+Tt2w+d3sSlsXYSnA=; b=XNx7LNAm+XD6FijC0I3644c6+HKIJ9SHo1T1TUGiWHHxkEyIJQZMBL66Rfw7ovuzABjKyQ LDA87Ha5d2EoI4uRpRxTdm/zuSuzb/AhmoBSaan/mIMfUFgKySvKXDS8Doyc/orafDj784 xHJlc121UZUVRVftAjfXD6gNmAHWeSI= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-lL33gmI2Py22NyPwFE-ehw-1; Mon, 24 Mar 2025 05:12:59 -0400 X-MC-Unique: lL33gmI2Py22NyPwFE-ehw-1 X-Mimecast-MFC-AGG-ID: lL33gmI2Py22NyPwFE-ehw_1742807579 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E96C6180AF4E; Mon, 24 Mar 2025 09:12:58 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.56]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2CA7D1956095; Mon, 24 Mar 2025 09:12:56 +0000 (UTC) Date: Mon, 24 Mar 2025 09:12:53 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Daan De Meyer Cc: qemu-devel@nongnu.org Subject: Re: [PATCH] smbios: Fix buffer overrun when using path= option Message-ID: References: <20250323213622.2581013-1-daan.j.demeyer@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250323213622.2581013-1-daan.j.demeyer@gmail.com> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sun, Mar 23, 2025 at 10:35:54PM +0100, Daan De Meyer wrote: > We have to make sure the array of bytes read from the path= file > is null-terminated, otherwise we run into a buffer overrun later on. > > Fixes: bb99f4772f54017490e3356ecbb3df25c5d4537f ("hw/smbios: support loading OEM strings values from a file") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2879 > > Signed-off-by: Daan De Meyer > --- > hw/smbios/smbios.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c > index 02a09eb9cd..ad4cd6721e 100644 > --- a/hw/smbios/smbios.c > +++ b/hw/smbios/smbios.c > @@ -1285,6 +1285,9 @@ static int save_opt_one(void *opaque, > g_byte_array_append(data, (guint8 *)buf, ret); > } > > + buf[0] = '\0'; > + g_byte_array_append(data, (guint8 *)buf, 1); > + > qemu_close(fd); > > *opt->dest = g_renew(char *, *opt->dest, (*opt->ndest) + 1); Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|