Re: [PATCH] tests/functional: Add missing require_netdev('user') statements

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Mar 24, 2025 at 01:34:50PM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> A bunch of tests are using "-netdev user" but fail to check
> for the availability of SLIRP in the binary, so these tests
> fail if QEMU has been configured with "--disable-slirp"
> (most of the tests are disabled by default with a decorator,
> that's likely why nobody noticed this problem yet). Add the
> missing self.require_netdev('user') statements to skip the
> tests if SLIRP is not available.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/functional/test_aarch64_rme_sbsaref.py | 1 +
>  tests/functional/test_aarch64_rme_virt.py    | 4 +++-
>  tests/functional/test_arm_bpim2u.py          | 2 ++
>  tests/functional/test_arm_cubieboard.py      | 2 ++
>  tests/functional/test_arm_orangepi.py        | 4 ++++
>  tests/functional/test_ppc64_hv.py            | 3 +++
>  tests/functional/test_x86_64_kvm_xen.py      | 1 +
>  7 files changed, 16 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|