From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>
Cc: "thierry.bultel@linatsea.fr" <thierry.bultel@linatsea.fr>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"geert@linux-m68k.org" <geert@linux-m68k.org>,
Paul Barker <paul.barker.ct@bp.renesas.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI
Date: Mon, 24 Mar 2025 22:56:31 +0100 [thread overview]
Message-ID: <Z-HVD6w6ivYR6pt5@shikoro> (raw)
In-Reply-To: <TYCPR01MB114922CBDC2911E2F644BDADC8AA42@TYCPR01MB11492.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 680 bytes --]
> > > +config SERIAL_RZ_SCI
> >
> > I think this name is too generic. Most RZ-variants so far do not have this
> > SoC. Would 'RZT2H' work or is it too narrow then?
>
> This is too narrow, because for instance the RZ/N2H , which is very similar, has the same SCI
You know the differences better, what could be a suitable name?
> > > #define PORT_GENERIC (-1)
> >
> > Does userspace need to know this port? Can't we use PORT_GENERIC?
>
> Userspace unlikely needs it. But unfortunately, the port type needs to
> be checked at a number (5) of places in the driver, so the definition
> is needed.
Yes, true. You just keep consistent with the driver. OK.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-03-24 21:56 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 15:24 [PATCH v4 00/13] Add initial support for Renesas RZ/T2H SoC Thierry Bultel
2025-03-06 15:24 ` [PATCH v4 01/13] dt-bindings: soc: Add Renesas RZ/T2H (R9A09G077) SoC Thierry Bultel
2025-03-07 21:40 ` Rob Herring (Arm)
2025-03-06 15:24 ` [PATCH v4 02/13] dt-bindings: clock: Add cpg for the Renesas RZ/T2H SoC Thierry Bultel
2025-03-07 21:43 ` Rob Herring
2025-03-06 15:24 ` [PATCH v4 03/13] dt-bindings: serial: Add compatible for Renesas RZ/T2H SoC in sci Thierry Bultel
2025-03-07 21:45 ` Rob Herring (Arm)
2025-03-06 15:24 ` [PATCH v4 04/13] soc: renesas: Add RZ/T2H (R9A09G077) config option Thierry Bultel
2025-03-06 15:24 ` [PATCH v4 05/13] clk: renesas: Pass sub struct of cpg_mssr_priv to cpg_clk_register Thierry Bultel
2025-03-06 15:24 ` [PATCH v4 06/13] clk: renesas: Add support for R9A09G077 SoC Thierry Bultel
2025-03-06 15:24 ` [PATCH v4 07/13] serial: sh-sci: Fix a comment about SCIFA Thierry Bultel
2025-03-18 21:50 ` Wolfram Sang
2025-03-06 15:24 ` [PATCH v4 08/13] serial: sh-sci: Introduced function pointers Thierry Bultel
2025-03-14 11:05 ` Geert Uytterhoeven
2025-03-17 9:55 ` Wolfram Sang
2025-03-17 10:27 ` Paul Barker
2025-03-18 21:45 ` Wolfram Sang
2025-03-24 9:25 ` Wolfram Sang
2025-03-24 10:02 ` Geert Uytterhoeven
2025-03-06 15:24 ` [PATCH v4 09/13] serial: sh-sci: Introduced sci_of_data Thierry Bultel
2025-03-24 9:37 ` Wolfram Sang
2025-03-24 10:03 ` Geert Uytterhoeven
2025-03-06 15:24 ` [PATCH v4 10/13] serial: sh-sci: Add support for RZ/T2H SCI Thierry Bultel
2025-03-24 9:43 ` Wolfram Sang
2025-03-24 12:49 ` Thierry Bultel
2025-03-24 21:56 ` Wolfram Sang [this message]
2025-03-25 6:29 ` Biju Das
2025-03-25 7:51 ` Wolfram Sang
2025-03-25 10:49 ` Thierry Bultel
2025-03-25 11:06 ` Wolfram Sang
2025-03-25 16:24 ` Geert Uytterhoeven
2025-03-06 15:24 ` [PATCH v4 11/13] arm64: dts: renesas: Add initial support for renesas RZ/T2H SoC Thierry Bultel
2025-03-06 15:24 ` [PATCH v4 12/13] arm64: dts: renesas: Add initial support for renesas RZ/T2H eval board Thierry Bultel
2025-03-06 15:24 ` [PATCH v4 13/13] arm64: defconfig: Enable Renesas RZ/T2H serial SCI Thierry Bultel
2025-03-24 9:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-HVD6w6ivYR6pt5@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=paul.barker.ct@bp.renesas.com \
--cc=thierry.bultel.yh@bp.renesas.com \
--cc=thierry.bultel@linatsea.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.