From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: mailhol.vincent@wanadoo.fr
Cc: Yury Norov <yury.norov@gmail.com>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Andi Shyti <andi.shyti@linux.intel.com>,
David Laight <David.Laight@aculab.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 5/6] test_bits: add tests for GENMASK_U*()
Date: Tue, 25 Mar 2025 18:26:04 +0200 [thread overview]
Message-ID: <Z-LZHD7sxiOImzu3@smile.fi.intel.com> (raw)
In-Reply-To: <20250326-fixed-type-genmasks-v8-5-24afed16ca00@wanadoo.fr>
On Wed, Mar 26, 2025 at 01:00:00AM +0900, Vincent Mailhol via B4 Relay wrote:
> From: Lucas De Marchi <lucas.demarchi@intel.com>
>
> Add some additional tests in lib/tests/test_bits.c to cover the
> expected/non-expected values of the fixed-type GENMASK_U*() macros.
>
> Also check that the result value matches the expected type. Since
> those are known at build time, use static_assert() instead of normal
> kunit tests.
New tests always have a green light to go from my point of view,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-25 16:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 15:59 [PATCH v8 0/6] bits: Fixed-type GENMASK_U*() and BIT_U*() Vincent Mailhol
2025-03-25 15:59 ` Vincent Mailhol via B4 Relay
2025-03-25 15:59 ` [PATCH v8 1/6] bits: add comments and newlines to #if, #else and #endif directives Vincent Mailhol
2025-03-25 15:59 ` Vincent Mailhol via B4 Relay
2025-03-25 16:20 ` Andy Shevchenko
2025-03-25 15:59 ` [PATCH v8 2/6] bits: introduce fixed-type GENMASK_U*() Vincent Mailhol
2025-03-25 15:59 ` Vincent Mailhol via B4 Relay
2025-03-25 16:24 ` Andy Shevchenko
2025-03-25 15:59 ` [PATCH v8 3/6] bits: introduce fixed-type BIT_U*() Vincent Mailhol
2025-03-25 15:59 ` Vincent Mailhol via B4 Relay
2025-03-25 16:27 ` Andy Shevchenko
2025-03-25 15:59 ` [PATCH v8 4/6] drm/i915: Convert REG_GENMASK*() to fixed-width GENMASK_U*() Vincent Mailhol
2025-03-25 15:59 ` Vincent Mailhol via B4 Relay
2025-03-25 16:00 ` [PATCH v8 5/6] test_bits: add tests for GENMASK_U*() Vincent Mailhol
2025-03-25 16:00 ` Vincent Mailhol via B4 Relay
2025-03-25 16:26 ` Andy Shevchenko [this message]
2025-03-25 16:00 ` [PATCH v8 6/6] test_bits: add tests for BIT_U*() Vincent Mailhol
2025-03-25 16:00 ` Vincent Mailhol via B4 Relay
2025-03-25 16:26 ` Andy Shevchenko
2025-03-25 22:22 ` ✗ Fi.CI.CHECKPATCH: warning for bits: Fixed-type GENMASK_U*() and BIT_U*() (rev3) Patchwork
2025-03-25 22:22 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-03-25 22:48 ` ✓ i915.CI.BAT: success " Patchwork
2025-03-26 2:23 ` ✗ i915.CI.Full: failure " Patchwork
2025-03-26 13:37 ` [PATCH v8 0/6] bits: Fixed-type GENMASK_U*() and BIT_U*() Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-LZHD7sxiOImzu3@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=David.Laight@aculab.com \
--cc=airlied@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andi.shyti@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lucas.demarchi@intel.com \
--cc=mailhol.vincent@wanadoo.fr \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=tursulin@ursulin.net \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.