From: Kevin Wolf <kwolf@redhat.com>
To: ~h0lyalg0rithm <surajshirvankar@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>
Subject: Re: [PATCH qemu 1/1] Add IOURING_SETUP_SINGLE_ISSUER flag to improve iouring performance
Date: Wed, 26 Mar 2025 18:13:44 +0100 [thread overview]
Message-ID: <Z-Q1yDqmS3gniW4X@redhat.com> (raw)
In-Reply-To: <174293621917.22751.11381319865102029969-1@git.sr.ht>
Am 25.03.2025 um 21:49 hat ~h0lyalg0rithm geschrieben:
> From: Suraj Shirvankar <surajshirvankar@gmail.com>
>
> Signed-off-by: Suraj Shirvankar <surajshirvankar@gmail.com>
> ---
> util/fdmon-io_uring.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
As Stefan already mentioned, the commit message should say why we want
to set this flag and why it is correct to do so.
Is there a reason why you change the io_uring_queue_init() call in
util/fdmon-io_uring.c, but not the one in block/io_uring.c?
If so, please document it in the commit message, too.
Kevin
next prev parent reply other threads:[~2025-03-26 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 20:56 [PATCH qemu 0/1] Add IOURING_SETUP_SINGLE_ISSUER flag to improve iouring performance ~h0lyalg0rithm
2025-03-25 20:49 ` [PATCH qemu 1/1] " ~h0lyalg0rithm
2025-03-26 14:57 ` Stefan Hajnoczi
2025-03-26 17:13 ` Kevin Wolf [this message]
2025-03-26 17:46 ` Stefan Hajnoczi
2025-03-27 13:14 ` Kevin Wolf
2025-04-01 14:44 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-Q1yDqmS3gniW4X@redhat.com \
--to=kwolf@redhat.com \
--cc=fam@euphon.net \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=surajshirvankar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.