Re: [PATCH sched_ext/for-6.15-fixes] sched_ext: Remove a meaningless conditional goto in scx_select_cpu_dfl()

[Andrea Righi <arighi@nvidia.com>]

On Wed, Mar 26, 2025 at 10:12:11AM -1000, Tejun Heo wrote:
> scx_select_cpu_dfl() has a meaningless conditional goto at the end. Remove
> it. No functional changes.
> 
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Andrea Righi <arighi@nvidia.com>

Looks good, thanks!

Acked-by: Andrea Righi <arighi@nvidia.com>

-Andrea

> ---
> Applied to sched_ext/for-6.15-fixes. Thanks.
> 
>  kernel/sched/ext_idle.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/sched/ext_idle.c b/kernel/sched/ext_idle.c
> index 45061b584380..b5f451e616d4 100644
> --- a/kernel/sched/ext_idle.c
> +++ b/kernel/sched/ext_idle.c
> @@ -584,8 +584,6 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64
>  	 * increasing distance.
>  	 */
>  	cpu = scx_pick_idle_cpu(p->cpus_ptr, node, flags);
> -	if (cpu >= 0)
> -		goto out_unlock;
>  
>  out_unlock:
>  	rcu_read_unlock();
> -- 
> 2.48.1
>