From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 4/4] src: remove flagcmp expression
Date: Wed, 26 Mar 2025 22:06:17 +0100 [thread overview]
Message-ID: <Z-RsSTyGARhxluoa@calendula> (raw)
In-Reply-To: <20250326203325.GC2205@breakpoint.cc>
On Wed, Mar 26, 2025 at 09:33:25PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > EXPR_SET_ELEM_CATCHALL,
> > - EXPR_FLAGCMP,
> > EXPR_RANGE_VALUE,
> > EXPR_RANGE_SYMBOL,
> >
> > - EXPR_MAX = EXPR_FLAGCMP
> > + EXPR_MAX = EXPR_SET_ELEM_CATCHALL
> > };
>
> This is strange, why is EXPR_MAX not set to last expression?
>
> Perhaps this should be changed to __EXPR_MAX
> #define EXPR_MAX (__EXPR_MAX-1)
>
> like we do elsewhere so this doesn't have to be
> updated all the time?
That's a good idea, I will send a v2 of this:
https://patchwork.ozlabs.org/project/netfilter-devel/patch/20250326210511.188767-1-pablo@netfilter.org/
prev parent reply other threads:[~2025-03-26 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 20:23 [PATCH nft 1/4] optimize: incorrect comparison for reject statement Pablo Neira Ayuso
2025-03-26 20:23 ` [PATCH nft 2/4] optimize: compact bitmask matching in set/map Pablo Neira Ayuso
2025-03-26 20:23 ` [PATCH nft 3/4] src: transform flag match expression to binop expression from parser Pablo Neira Ayuso
2025-03-26 20:23 ` [PATCH nft 4/4] src: remove flagcmp expression Pablo Neira Ayuso
2025-03-26 20:33 ` Florian Westphal
2025-03-26 21:06 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-RsSTyGARhxluoa@calendula \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.