From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, krzk@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V2 1/2] gpiolib: of: Add polarity quirk for s5m8767
Date: Thu, 27 Mar 2025 12:15:11 +0200 [thread overview]
Message-ID: <Z-UlL_zpdAvi0UcK@smile.fi.intel.com> (raw)
In-Reply-To: <20250327004945.563765-1-peng.fan@oss.nxp.com>
On Thu, Mar 27, 2025 at 08:49:44AM +0800, Peng Fan (OSS) wrote:
>
> This is prepare patch for switching s5m8767 regulator driver to
> use GPIO descriptor. DTS for exynos5250 spring incorrectly specifies
> "active low" polarity for the DVS and DS line. But per datasheet,
> they are actually active high. So add polarity quirk for it.
So, to make this clear: this is simply DTS mistake as driver basically ignores
the polarity or other flags in it, correct?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-27 10:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 0:49 [PATCH V2 1/2] gpiolib: of: Add polarity quirk for s5m8767 Peng Fan (OSS)
2025-03-27 0:49 ` [PATCH V2 2/2] regulator: s5m8767: Convert to GPIO descriptors Peng Fan (OSS)
2025-03-27 11:37 ` Andy Shevchenko
2025-03-27 12:03 ` Mark Brown
2025-03-27 16:54 ` Krzysztof Kozlowski
2025-03-28 7:49 ` Linus Walleij
2025-03-27 8:55 ` [PATCH V2 1/2] gpiolib: of: Add polarity quirk for s5m8767 Bartosz Golaszewski
2025-03-27 12:05 ` Mark Brown
2025-03-27 10:15 ` Andy Shevchenko [this message]
2025-03-27 10:25 ` Peng Fan
2025-03-28 7:50 ` Linus Walleij
2025-04-07 7:42 ` (subset) " Bartosz Golaszewski
2025-04-07 22:15 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-UlL_zpdAvi0UcK@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.