From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A0C0C3600B for ; Thu, 27 Mar 2025 10:58:46 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.928984.1331620 (Exim 4.92) (envelope-from ) id 1txkwU-0005JY-6o; Thu, 27 Mar 2025 10:58:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 928984.1331620; Thu, 27 Mar 2025 10:58:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1txkwU-0005JR-3t; Thu, 27 Mar 2025 10:58:34 +0000 Received: by outflank-mailman (input) for mailman id 928984; Thu, 27 Mar 2025 10:58:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1txkwT-0005JL-Eh for xen-devel@lists.xenproject.org; Thu, 27 Mar 2025 10:58:33 +0000 Received: from mail132-31.atl131.mandrillapp.com (mail132-31.atl131.mandrillapp.com [198.2.132.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69327ca3-0afa-11f0-9ffa-bf95429c2676; Thu, 27 Mar 2025 11:58:27 +0100 (CET) Received: from pmta09.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail132-31.atl131.mandrillapp.com (Mailchimp) with ESMTP id 4ZNgcf3BS9z9K7mVK for ; Thu, 27 Mar 2025 10:58:26 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 52635a0dd82245e7b6b928a6286be143; Thu, 27 Mar 2025 10:58:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69327ca3-0afa-11f0-9ffa-bf95429c2676 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1743073106; x=1743343106; bh=3gQDj1sCyJJAp3xr2euRSpfyou6KSLvk5zRRTiv3Tb0=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=cn4tW4eXpvGL7QXEm0HneavTu6bHvcDZPUxL3RSvthg6LjY/dzyQ9TzSSjRBSW/Jk FKssdijCE6o9ZqEABQ8xxO/p5yYjWyH52Y5CP5PnnMV7xPG3DaQmu2cihYVVIy/Yz3 sLgopchHsdZP/JlG/acJRW8G1OQRgoJYLVJqQTOkSTK28in9CaUdd96W3eQv6Ib89t YoLokX6I0TPbwuSROsbRsSJjjrX9rHUvNrepU17CtOdwiYzIIJFHTsKnTdnfqoHK0k dcZDHd+BjA52NZrL81yfaA7be0TRLX7fQpTauxZ9kLXtnM8vuJG8O8lEM8iIYXyLkp 0aUNnTukfhtmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1743073106; x=1743333606; i=anthony.perard@vates.tech; bh=3gQDj1sCyJJAp3xr2euRSpfyou6KSLvk5zRRTiv3Tb0=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=sgPbFcv7Wj0f+iC2ZRSy6c2IK0iR1a6u2chDBXEx8UxqRzzDsTGCA60RCA5TmtIHf dSGvgQ7V/Bnzwx5df7dDz67010+454Oh/o/JVYh384FjRchnvnQG6XUCiIzcz+2cyQ LnMoeI4WuKjiNWp5oxV9g3Yt82GOt2q2hli2d1pVwffoMcyqoP63rxqYQL3nPc+oEh XS5tTmZGGd68PQa/i8wINLifAMGlzay5KQzHB5dtuD6fcDxOFL9OOdVWtAS0KE1A7z rjHoDUYJejbp4/uQUp6S+P4XWjQgq5bgQ338qYi05rnoF39Oi5lKos9niXgKXsSGWt ZA0nRfgHPaPxA== From: "Anthony PERARD" Subject: =?utf-8?Q?Re:=20[XEN=20PATCH]=20automation:=20Avoid=20changing=20source=20files=20for=20randconfig=20tests?= X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1743073105572 To: "Stefano Stabellini" Cc: xen-devel@lists.xenproject.org, "Doug Goldstein" Message-Id: References: <20250326142754.5441-1-anthony.perard@vates.tech> In-Reply-To: X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message,=20including=20all=20headers,=20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.52635a0dd82245e7b6b928a6286be143?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20250327:md Date: Thu, 27 Mar 2025 10:58:26 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On Wed, Mar 26, 2025 at 07:10:52PM -0700, Stefano Stabellini wrote: > On Wed, 26 Mar 2025, Anthony PERARD wrote: > > diff --git a/automation/scripts/build b/automation/scripts/build > > index 522efe774e..8a3b8fb6b2 100755 > > --- a/automation/scripts/build > > +++ b/automation/scripts/build > > @@ -12,12 +12,12 @@ $cc --version > > # random config or default config > > if [[ "${RANDCONFIG}" == "y" ]]; then > > > > - # Append job-specific fixed configuration > > - if [[ -n "${EXTRA_FIXED_RANDCONFIG}" ]]; then > > - echo "${EXTRA_FIXED_RANDCONFIG}" >> xen/tools/kconfig/allrandom.config > > - fi > > + cp -f xen/tools/kconfig/allrandom.config xen/allrandom.config.tmp > > Wouldn't it be better to use mktemp? > > local tmpconfig=$(mktemp) I though of it and I wasn't sure if we could use it in the CI, but it's already been used so that's an option. (Actually, there's only a single use by ./check-endbr.sh, ./configure does use it as well but to create temporary directory within the build tree.) But, to avoid overflowing /tmp with loads of leftover temporary files, we need to clean it, with: trap "rm $tmpconfig" EXIT The advantage of using an in-tree files with a predefined name is that it isn't going to create more than one file, no matter how many time you run ./build. The '*.tmp' files are already ignored by our .gitignore. I could rename it to with a "." to hide it a bit more. Thanks, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech