From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: "Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Broadcom internal kernel review list"
<bcm-kernel-feedback-list@broadcom.com>,
"Marek Behún" <kabel@kernel.org>,
"Eric Woudstra" <ericwouds@gmail.com>,
"Daniel Golle" <daniel@makrotopia.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-next RFC PATCH v3 2/4] net: phy: bcm87xx: simplify .match_phy_device OP
Date: Thu, 27 Mar 2025 11:08:15 +0000 [thread overview]
Message-ID: <Z-Uxn3hlJQ62bBGw@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250326233512.17153-3-ansuelsmth@gmail.com>
On Thu, Mar 27, 2025 at 12:35:02AM +0100, Christian Marangi wrote:
> Simplify .match_phy_device OP by using a generic function and using the
> new phy_id PHY driver info instead of hardcoding the matching PHY ID.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> drivers/net/phy/bcm87xx.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
Great! Less code! :)
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2025-03-27 11:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 23:35 [net-next RFC PATCH v3 0/4] net: phy: Add support for new Aeonsemi PHYs Christian Marangi
2025-03-26 23:35 ` [net-next RFC PATCH v3 1/4] net: phy: pass PHY driver to .match_phy_device OP Christian Marangi
2025-03-27 3:03 ` kernel test robot
2025-03-27 4:31 ` kernel test robot
2025-03-27 11:07 ` Russell King (Oracle)
2025-03-27 14:15 ` Christian Marangi
2025-03-26 23:35 ` [net-next RFC PATCH v3 2/4] net: phy: bcm87xx: simplify " Christian Marangi
2025-03-27 11:08 ` Russell King (Oracle) [this message]
2025-03-26 23:35 ` [net-next RFC PATCH v3 3/4] net: phy: Add support for Aeonsemi AS21xxx PHYs Christian Marangi
2025-03-27 8:24 ` Maxime Chevallier
2025-03-27 11:24 ` Christian Marangi
2025-03-27 11:24 ` Russell King (Oracle)
2025-03-27 11:26 ` Russell King (Oracle)
2025-03-27 11:30 ` Christian Marangi
2025-03-27 11:36 ` Christian Marangi
2025-03-26 23:35 ` [net-next RFC PATCH v3 4/4] dt-bindings: net: Document support for Aeonsemi PHYs Christian Marangi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-Uxn3hlJQ62bBGw@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew+netdev@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=kabel@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.