From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45C74C3600B for ; Thu, 27 Mar 2025 17:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zAHWc9oWR8FH6YNJYn0UNlY5W9SION0+za89fMFokk4=; b=gEZ+9IoeqTwI08 ZJIk5cA3w3m9nSN18a8iu2FbUOVDTkYRCZiehZAsCrtpbRFRLcVXA+dgilEVZ0Dn2Fbi/Y5ZKwjZ+ zV3pPAPM9FChIDxmO9LSdMldt58O8bMtU62PNnUc0BeMmh7MmigwUXm3cIaVX2b8XSwVIG0MTxm7J uJON4asB5++kwAnoxz2R/9T7sLDS1h1AeEzPpuJd351bGKOOwAamijXzbZ6FIdD5WUTmJ88shgwIw WLQl8Z1Mwziuw/YjhiLnq6mMZ0PC2I69tdxOVWuHXQIp2wIiQJ4HaJqslu63yhygriki4G4Ee5kUC WMpwXRXwp4NSr5mHfkYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1txqlR-0000000BctA-4AqI; Thu, 27 Mar 2025 17:11:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1txqlO-0000000BcsL-3RmS for kvm-riscv@lists.infradead.org; Thu, 27 Mar 2025 17:11:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDCD81063; Thu, 27 Mar 2025 10:11:32 -0700 (PDT) Received: from raptor (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 645FE3F63F; Thu, 27 Mar 2025 10:11:26 -0700 (PDT) Date: Thu, 27 Mar 2025 17:11:23 +0000 From: Alexandru Elisei To: Jean-Philippe Brucker Cc: andrew.jones@linux.dev, eric.auger@redhat.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, vladimir.murzin@arm.com Subject: Re: [kvm-unit-tests PATCH v3 1/5] configure: arm64: Don't display 'aarch64' as the default architecture Message-ID: References: <20250325160031.2390504-3-jean-philippe@linaro.org> <20250325160031.2390504-4-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250325160031.2390504-4-jean-philippe@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250327_101130_931010_EA068721 X-CRM114-Status: GOOD ( 17.40 ) X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org Hi Jean-Philippe On Tue, Mar 25, 2025 at 04:00:29PM +0000, Jean-Philippe Brucker wrote: > From: Alexandru Elisei > > --arch=aarch64, intentional or not, has been supported since the initial > arm64 support, commit 39ac3f8494be ("arm64: initial drop"). However, > "aarch64" does not show up in the list of supported architectures, but > it's displayed as the default architecture if doing ./configure --help > on an arm64 machine. > > Keep everything consistent and make sure that the default value for > $arch is "arm64", but still allow --arch=aarch64, in case they are users > that use this configuration for kvm-unit-tests. You can drop this paragraph, since the change to the default value for $arch was dropped. With this change: Reviewed-by: Alexandru Elisei Thanks, Alex > > The help text for --arch changes from: > > --arch=ARCH architecture to compile for (aarch64). ARCH can be one of: > arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > > to: > > --arch=ARCH architecture to compile for (arm64). ARCH can be one of: > arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > > Signed-off-by: Alexandru Elisei > Signed-off-by: Jean-Philippe Brucker > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure > index 52904d3a..010c68ff 100755 > --- a/configure > +++ b/configure > @@ -43,6 +43,7 @@ else > fi > > usage() { > + [ "$arch" = "aarch64" ] && arch="arm64" > cat <<-EOF > Usage: $0 [options] > > -- > 2.49.0 > -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5CBC01DFF8 for ; Thu, 27 Mar 2025 17:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743095491; cv=none; b=alqiyAeV2nLHOBZFfCmIybfWbVx5wfxdQiN83+pqjRY1KwC7PYAP3V/Wb4vq6Mey4jDEObpIv9U+ko1r1w/jMtRCEPvrDpI73yYxAW6f16xGlWDFMuDvbOS0D47vOZ8Ju6hBmBh+458fGsXC6TNb+kBajQz/Nkih2QfeiGcEo+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743095491; c=relaxed/simple; bh=BuEIdozODnu8Pi8cV2q1qibFyh11cZdTbxRUiasKPU8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=H+MoeVw0a+n2xFSuns6TRDfzIHGwjsqPfV/lAGm8GdjAV3kWXJOWfwjCzlFB5NtaDifdENBwPxuf/AlhsH45xdt3eQJ7ec378DWMLpvpqBoscwSs6Y4kBPCXmdf8G8YMeZnmSowk88ghhPfJyRaNHXWb1knMkhVZXMUw+fW5rZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDCD81063; Thu, 27 Mar 2025 10:11:32 -0700 (PDT) Received: from raptor (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 645FE3F63F; Thu, 27 Mar 2025 10:11:26 -0700 (PDT) Date: Thu, 27 Mar 2025 17:11:23 +0000 From: Alexandru Elisei To: Jean-Philippe Brucker Cc: andrew.jones@linux.dev, eric.auger@redhat.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, vladimir.murzin@arm.com Subject: Re: [kvm-unit-tests PATCH v3 1/5] configure: arm64: Don't display 'aarch64' as the default architecture Message-ID: References: <20250325160031.2390504-3-jean-philippe@linaro.org> <20250325160031.2390504-4-jean-philippe@linaro.org> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250325160031.2390504-4-jean-philippe@linaro.org> Hi Jean-Philippe On Tue, Mar 25, 2025 at 04:00:29PM +0000, Jean-Philippe Brucker wrote: > From: Alexandru Elisei > > --arch=aarch64, intentional or not, has been supported since the initial > arm64 support, commit 39ac3f8494be ("arm64: initial drop"). However, > "aarch64" does not show up in the list of supported architectures, but > it's displayed as the default architecture if doing ./configure --help > on an arm64 machine. > > Keep everything consistent and make sure that the default value for > $arch is "arm64", but still allow --arch=aarch64, in case they are users > that use this configuration for kvm-unit-tests. You can drop this paragraph, since the change to the default value for $arch was dropped. With this change: Reviewed-by: Alexandru Elisei Thanks, Alex > > The help text for --arch changes from: > > --arch=ARCH architecture to compile for (aarch64). ARCH can be one of: > arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > > to: > > --arch=ARCH architecture to compile for (arm64). ARCH can be one of: > arm, arm64, i386, ppc64, riscv32, riscv64, s390x, x86_64 > > Signed-off-by: Alexandru Elisei > Signed-off-by: Jean-Philippe Brucker > --- > configure | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/configure b/configure > index 52904d3a..010c68ff 100755 > --- a/configure > +++ b/configure > @@ -43,6 +43,7 @@ else > fi > > usage() { > + [ "$arch" = "aarch64" ] && arch="arm64" > cat <<-EOF > Usage: $0 [options] > > -- > 2.49.0 >