From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A29EC28B20 for ; Fri, 28 Mar 2025 11:01:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 07DB510E9E3; Fri, 28 Mar 2025 11:01:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="R/9r3fIP"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1A39410E9E3; Fri, 28 Mar 2025 11:01:48 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id C3B04614B4; Fri, 28 Mar 2025 11:01:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6976AC4CEE4; Fri, 28 Mar 2025 11:01:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743159702; bh=4vR8XRswEcbeL+RPvYmMfrweBQ190iuWvm0Je9EsKYk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R/9r3fIPYj/ps3KXy1Z6/3LE2y6u43k3U039GsWELz8dEOKJ7+SCoLif7Bca5eyxU A1qBazYDMi6pJdhU3nkmawkR1TmGh4PnGgOUP+OP4tezzTlv9xBCy52Vp4ajIGrGfo ya1XNLi0xNiNiBJO3s7Qv3+Dw+W8Fn8ekOoZGwooQiP0PmNMKcL+jHl1dsOFRPyjYv oAHZeOWB5dqy/CyUkY8w2CJTISMkryuvbaeWYpZTMTbNpQBT5Z6giZKLNE+zX8GaUG MU+WS7RJrBymSIRHcR78Ste4fouYaYTcM3AHb66Yb/6VteeANa1GqtwPembSnOkHcd 6MrbuUd3BqKyQ== Date: Fri, 28 Mar 2025 12:01:37 +0100 From: Danilo Krummrich To: Chris Bainbridge Cc: Christian =?iso-8859-1?Q?K=F6nig?= , nouveau@lists.freedesktop.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, lyude@redhat.com, sumit.semwal@linaro.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/prime: fix drm_prime_gem_destroy comment Message-ID: References: <00e4d9c4-ecfc-4784-b603-12db04cda806@amd.com> <1f4a534f-8883-4793-b191-60c2773f6217@amd.com> <94eeb36a-9aa5-4afd-9ba6-76e8ace10122@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Wed, Mar 26, 2025 at 01:10:58PM +0000, Chris Bainbridge wrote: > Edit the comments on correct usage of drm_prime_gem_destroy to note > that, if using TTM, drm_prime_gem_destroy must be called in the > ttm_buffer_object.destroy hook, to avoid the dma_buf being freed leaving > a dangling pointer which will be later dereferenced by > ttm_bo_delayed_delete. > > Signed-off-by: Chris Bainbridge > Suggested-by: Christian König Can you please send new version of patches as a new mail thread (not in reply to previous versions) please? Otherwise, Reviewed-by: Danilo Krummrich @Christian, I assume you will pick this one up?