From: Oscar Salvador <osalvador@suse.de>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, hughd@google.com, willy@infradead.org,
david@redhat.com, 21cnbao@gmail.com, ziy@nvidia.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mm: mincore: use folio_pte_batch() to batch process large folios
Date: Fri, 28 Mar 2025 14:10:24 +0100 [thread overview]
Message-ID: <Z-afwA3UyEJxryBp@localhost.localdomain> (raw)
In-Reply-To: <54886038-3707-4ea0-bd84-00a8f4a19a6a@arm.com>
On Thu, Mar 27, 2025 at 10:08:56AM -0400, Ryan Roberts wrote:
> You could simplify to the following, I think, to avoid needing to grab the folio
> and call folio_pte_batch():
>
> else if (pte_present(pte)) {
> int max_nr = (end - addr) / PAGE_SIZE;
> step = min(pte_batch_hint(ptep, pte), max_nr);
> } ...
Yes, I think this makes much more sense, in the end, as you said, we do
not really need what folio_pte_batch gives us here.
With the API I am working on, batching will be done in there internally,
so we will not have to expose this here.
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2025-03-28 13:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 3:38 [PATCH 0/2] Fix mincore() tmpfs test failure Baolin Wang
2025-03-26 3:38 ` [PATCH 1/2] selftests: mincore: fix tmpfs mincore " Baolin Wang
2025-03-27 14:36 ` Zi Yan
2025-03-30 19:47 ` Baolin Wang
2025-04-01 12:54 ` David Hildenbrand
2025-04-07 3:49 ` Baolin Wang
2025-04-07 7:49 ` David Hildenbrand
2025-04-07 8:35 ` Baolin Wang
2025-03-26 3:38 ` [PATCH 2/2] mm: mincore: use folio_pte_batch() to batch process large folios Baolin Wang
2025-03-27 10:49 ` Oscar Salvador
2025-03-27 11:54 ` Baolin Wang
2025-03-27 14:08 ` Ryan Roberts
2025-03-28 13:10 ` Oscar Salvador [this message]
2025-03-30 19:57 ` Baolin Wang
2025-04-01 10:45 ` Ryan Roberts
2025-04-01 13:04 ` David Hildenbrand
2025-04-07 6:33 ` Baolin Wang
2025-04-14 13:46 ` Ryan Roberts
2025-05-07 5:12 ` Dev Jain
2025-05-07 9:48 ` Baolin Wang
2025-05-07 9:54 ` David Hildenbrand
2025-05-07 10:03 ` Baolin Wang
2025-05-07 11:14 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-afwA3UyEJxryBp@localhost.localdomain \
--to=osalvador@suse.de \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.