From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C89991CFBC for ; Fri, 28 Mar 2025 13:51:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743169919; cv=none; b=G8TyJ+YK79CDS9RsYDsB7uuUiwW1LB8/4DL0DZqYLC+OzeP4lxoh1iD+RfrJnBr4SR0j66oizvf7BQlvyelL9nsdVPyIsqfkYay/J9f92XC7jTyUSMitfC6ARCQUx5Md1zLlYiARueBN2vRfEcgHDMXsM3UlYWbi3mJUfCdyOAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743169919; c=relaxed/simple; bh=7keX5FQHfuj5criWs662qvX5Y0mvZuQ+wEIWA+09qU0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZdzTSj0/6KpLyh0Zt8MU0OBpos0kOxCkfhgqqIE5oP3PdrLDjuaaufk0d52EdWZ7TD9LIX7Kq0sp/e8LHZTjhTt/Wky4fh4I5+ahbi6uFed0mV3VPt2BFD5HS25GPtHd/p7qCFnFq+9HOKAY9QEvWyIbO38gUXFhroAPTa/vpIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Ri52rTuY; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Ri52rTuY" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3997205e43eso1812342f8f.0 for ; Fri, 28 Mar 2025 06:51:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1743169915; x=1743774715; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=olQvXU3SlpssZcd54ZBPK/yHAsySM9j/3+8owqmZXYk=; b=Ri52rTuY+auIlCiZoHCuVbwfsheeZHWQ1FjX+m0j7RQjXBzvmnDcfAW0Twomki44QH H/AY0m5enj43ba3w/UsyeJ9GYkolrQRZTj0eV53UxSJsBSqPM4ByLvPe0KqN2P6DMHRg MWFEjTiDp/OlbsZTBU1YrK/kxKLpkYT0M+O+QQrGU3FLG/EVTbYnGYumiplgEAWrlTas 8ZiXqcstegbn4gbJHY/us/tanKGWOsdXyaTqBSbkLY+N8nQm0iA34YdQC/PAv17XtEBL o8WhJH1ljNGuYE0dLHBm937FxgfZr23qPQxOsi8XGvRb2KcmtiyRk75tfmlTD9gWb8bm SUbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743169915; x=1743774715; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=olQvXU3SlpssZcd54ZBPK/yHAsySM9j/3+8owqmZXYk=; b=VOxOyMGZP3B5GDrqS7deL0PrWq9JcBPEL5DCp424mZMtXJMou4ynk3zNAevAiWqhYC 2IVjvyPQOf6UaNsC9zRVLUSvCnSOoKfhveQ21ThYInqDn1Tkv6zLRBGLUqqBlzsiXFGW aNLacyCalBhqj2YSx69Pn9dR9rIpyVHDpPwcAbSgN4gYQpmt/kw0yd6tMbcc0Po+yNmm wGdUrfcCU5/wy9Ka/yf1tCvR3bj5T2uRR7xniaV0YxoaQ3wGiBuVeGIaD7ELtQVgf5PR 7S5Epe8rkFRR28xBQUUjwzEueniYcTJJyj9ypT4BY7RqXxBJ28XkmpuZCIABeRZdKNcf nedg== X-Forwarded-Encrypted: i=1; AJvYcCV9ySO+yGawLFp3b7LxgY1vgENP74MXsMDvykdrc8KbOP4W/JObD8C/uA/RI+1fKIA4qYc2vaHPaUXqybjavwA=@vger.kernel.org X-Gm-Message-State: AOJu0YwS7KPiPcgxHIoq+P4qPLWsV3PeH01BEFbW39b4hwOabR7QX/nK OxNEHWzHoUr/sy9nyVqfQBNA+ReSGad9+xETsWw/G6WakBswnSSAld2w7CSCK+8= X-Gm-Gg: ASbGnct+pcSUF+bhadsCF61RhuFPp6LGelM1nSS8liBfhPScB1E2XF/6ssk40+raxU3 z7wWVGSMRRrzhqMN/pmnCQOtEmV8yAgRrqDcZu4PEQLg9cWw4vpI7JzMsg6ARxZ900ml4w8ajvW BiJbLWXOz4I6lEItSptckRZP4NYsdNjkOiDSESALpgDe5vdzZcUT+sMRVlfrw4coEjIWc+o3tXg c0gq7Cx/eRNtmR7OgwaRrcjibJggtzrG+PsGM4kUfSbbD5dje2iso0T9kcN1d3HV6tCPlsJ2adb zDGUWJVtvNyjO+two63Yq4h9VQvhoRazE3foASxCTdZfI0Q= X-Google-Smtp-Source: AGHT+IHbfndbuHfkuasI/Cf4p6r8nuRFhsT5d5n30IcceIH6HCihEcayWTwO3EYsoj8rQdERKU6JoQ== X-Received: by 2002:a5d:47a2:0:b0:391:3049:d58d with SMTP id ffacd0b85a97d-39ad1719a55mr6958877f8f.0.1743169915024; Fri, 28 Mar 2025 06:51:55 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8fba4b4fsm29091505e9.1.2025.03.28.06.51.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Mar 2025 06:51:54 -0700 (PDT) Date: Fri, 28 Mar 2025 14:51:52 +0100 From: Petr Mladek To: Andy Shevchenko Cc: Christophe JAILLET , Kees Cook , Steven Rostedt , "Masami Hiramatsu (Google)" , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Andy Shevchenko , Mathieu Desnoyers , Andrew Morton , Rasmus Villemoes , Sergey Senozhatsky Subject: Re: [PATCH v2 0/6] vsprintf: Add __printf attribute to where it's required Message-ID: References: <20250321144822.324050-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-hardening@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue 2025-03-25 11:15:21, Petr Mladek wrote: > On Fri 2025-03-21 16:40:46, Andy Shevchenko wrote: > > This whole series started from a simple fix (see the last patch) > > to make GCC (Debian 14.2.0-17) happy when compiling with `make W=1` > > (note, that CONFIG_WERROR=y and all warnings break the build!) > > down to a rabbit hole. > > > > However starting from v2 the last patch doesn't require the first > > part, I prefer still to have them since the functions, while being > > _binary_ printf()-like, are still printf()-like. It also puts in align > > the tracing stuff with the rest and fixes the wrong parameter value. > > > > These first 4 patches are organised in a strict order and can't be > > reshuffled, otherwise it will produce a warnings in between. > > > > I believe the best route for the series is printk tree with immutable > > tag or branch for the others. > > > > Alternatively the first 4 patches can be applied first as they > > are pretty much straightforward. They also can be squashed to one > > (as the same topic behind), but it all is up to the respective > > maintainers. > > The whole series looks good to me: > > Reviewed-by: Petr Mladek > > I am going to push it via the printk tree. I think about doing > so as a second pull request by the end of this merge window. > > Anyway, I am going to wait few more days for eventual feedback > or push back. JFYI, I have pushed the patchset into printk/linux.git, branch for-6.15-printf-attribute. I am going to send a pull request the following week if nothing happens in the meantime. Best Regards, Petr