From: "Anthony PERARD" <anthony.perard@vates.tech>
To: "Andrew Cooper" <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
"Michal Orzel" <michal.orzel@amd.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Julien Grall" <julien@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Oleksii Kurochko" <oleksii.kurochko@gmail.com>
Subject: Re: [PATCH v3] Xen: Update compiler checks
Date: Fri, 28 Mar 2025 14:05:35 +0000 [thread overview]
Message-ID: <Z-asrZ6OuK2lHJ_C@l14> (raw)
In-Reply-To: <20250327174302.412821-1-andrew.cooper3@citrix.com>
On Thu, Mar 27, 2025 at 05:43:02PM +0000, Andrew Cooper wrote:
> The $(eval $(check-y)) is badly positioned:
>
> xen.git/xen$ make
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> HOSTCC tools/fixdep
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> make[1]: *** [scripts/Makefile.host:108: tools/fixdep] Error 1
> HOSTCC tools/symbols
> *** FATAL BUILD ERROR: Xen requires at least GCC 0x150100
> make[1]: *** [scripts/Makefile.host:108: tools/symbols] Error 1
> make: *** [Makefile:610: xen] Error 2
>
> It is involved every time Config.mk is included, rather than once per `make`
> invocation.
It's worth than that ;-). $(eval $(check-y)) doesn't print anything, it
actually replace $(CC) by something that just print this error message
and thus refuse to build anything. So even if the eval was only done
once, you'll still have this stream of error message.
Anyway, is this check still useful somehow? Or could we replace it by a
check in ./configure for the tools and one in either Kconfig or
"xen/Makefile" for the hypervisor?
Cheers,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
next prev parent reply other threads:[~2025-03-28 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 17:43 [PATCH v3] Xen: Update compiler checks Andrew Cooper
2025-03-28 7:43 ` Jan Beulich
2025-03-28 14:05 ` Anthony PERARD [this message]
2025-03-28 16:30 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-asrZ6OuK2lHJ_C@l14 \
--to=anthony.perard@vates.tech \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=oleksii.kurochko@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.