From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
syzbot <syzbot+c38e5e60d0041a99dbf5@syzkaller.appspotmail.com>,
gregkh@linuxfoundation.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH v2 resend] media: dvb: usb: Fix WARNING in dib0700_i2c_xfer/usb_submit_urb
Date: Fri, 28 Mar 2025 16:45:10 +0100 [thread overview]
Message-ID: <Z-bEBk68dh918vy9@shikoro> (raw)
In-Reply-To: <c7f67d3b-f1e6-4d68-99aa-e462fdcb315f@rowland.harvard.edu>
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
Alan,
> Fix the problem by adding the I2C_AQ_NO_ZERO_LEN_READ adapter quirk
> flag to all the USB I2C adapter devices managed by dvb-usb-i2c.c,
> following Wolfram Sang's suggestion. This tells the I2C core not to
> allow length-0 read messages.
Thank you again for fixing this issue. There are some USB-I2C bridges in
drivers/i2c/busses which also do not prevent zero len reads. Would it
make sense to put a protection into the I2C core? Can we reliably detect
that an adapter sits on a USB (maybe via the parent device), so that we
can then check if I2C_AQ_NO_ZERO_LEN_READ is set, and take action if
not?
Appreciating your input,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-03-28 15:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-24 18:18 [syzbot] [usb?] WARNING in dib0700_i2c_xfer/usb_submit_urb syzbot
2025-03-24 19:08 ` Alan Stern
2025-03-24 19:19 ` Wolfram Sang
2025-03-25 16:41 ` Alan Stern
2025-03-25 16:59 ` Wolfram Sang
2025-03-25 17:47 ` Alan Stern
2025-03-25 19:07 ` syzbot
2025-03-25 19:28 ` [PATCH] media: dvb: usb: Fix " Alan Stern
2025-03-25 19:56 ` Wolfram Sang
2025-03-25 21:47 ` Alan Stern
2025-03-25 22:17 ` Wolfram Sang
2025-03-26 15:28 ` [PATCH v2] " Alan Stern
2025-03-26 15:54 ` Wolfram Sang
2025-03-26 16:04 ` Alan Stern
2025-03-26 21:32 ` Wolfram Sang
2025-03-27 16:10 ` [PATCH v2 resend] " Alan Stern
2025-03-28 15:45 ` Wolfram Sang [this message]
2025-03-29 2:08 ` Alan Stern
2025-03-29 6:05 ` Wolfram Sang
2025-03-29 14:31 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-bEBk68dh918vy9@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+c38e5e60d0041a99dbf5@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.