From: Stanislav Fomichev <stfomichev@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
jeroendb@google.com, hramamurthy@google.com,
pkaligineedi@google.com, willemb@google.com, shailend@google.com,
joshwash@google.com, sdf@fomichev.me
Subject: Re: [PATCH net] eth: gve: add missing netdev locks on reset and shutdown paths
Date: Fri, 28 Mar 2025 09:59:36 -0700 [thread overview]
Message-ID: <Z-bVeHQpkvzPrb0_@mini-arch> (raw)
In-Reply-To: <20250328164742.1268069-1-kuba@kernel.org>
On 03/28, Jakub Kicinski wrote:
> All the misc entry points end up calling into either gve_open()
> or gve_close(), they take rtnl_lock today but since the recent
> instance locking changes should also take the instance lock.
>
> Found by code inspection and untested.
>
> Fixes: cae03e5bdd9e ("net: hold netdev instance lock during queue operations")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
next prev parent reply other threads:[~2025-03-28 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 16:47 [PATCH net] eth: gve: add missing netdev locks on reset and shutdown paths Jakub Kicinski
2025-03-28 16:59 ` Stanislav Fomichev [this message]
2025-03-28 21:55 ` Harshitha Ramamurthy
2025-04-01 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-bVeHQpkvzPrb0_@mini-arch \
--to=stfomichev@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=sdf@fomichev.me \
--cc=shailend@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.