From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Arnd Bergmann <arnd@arndb.de>,
Adrian Hunter <adrian.hunter@intel.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: renesas_sdhi: add regulator dependency
Date: Sat, 29 Mar 2025 10:46:09 +0100 [thread overview]
Message-ID: <Z-fBYVzkxZOqZixB@shikoro> (raw)
In-Reply-To: <20250329082123.2325267-1-arnd@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Sat, Mar 29, 2025 at 09:20:52AM +0100, Arnd Bergmann wrote:
> config MMC_SDHI
> tristate "Renesas SDHI SD/SDIO controller support"
> - depends on SUPERH || ARCH_RENESAS || COMPILE_TEST
> + depends on SUPERH || (ARCH_RENESAS && RESET_CONTROLLER) || COMPILE_TEST
> + depends on REGULATOR
Hmm, this is too strict IMO. SuperH does not need REGULATOR. But adding
REGULATOR to ARCH_RENESAS like RESET_CONTROLLER will still fail for
COMPILE_TEST, right?
Maybe we need to maintain the dependency in Kconfig after all:
depends on REGULATOR if ARCH_R8A<whichever needs it>
?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-03-29 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 8:20 [PATCH] mmc: renesas_sdhi: add regulator dependency Arnd Bergmann
2025-03-29 9:46 ` Wolfram Sang [this message]
2025-03-29 10:46 ` Arnd Bergmann
2025-03-29 11:46 ` Wolfram Sang
2025-03-29 12:49 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-fBYVzkxZOqZixB@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.