From: Luis Chamberlain <mcgrof@kernel.org>
To: Daniel Gomez <da.gomez@kernel.org>
Cc: kdevops@lists.linux.dev
Subject: Re: [PATCH 5/6] guestfs: add ansible group permisison check on libvirt system uri
Date: Sat, 29 Mar 2025 15:43:05 -0700 [thread overview]
Message-ID: <Z-h3eTCpRC28eaCm@bombadil.infradead.org> (raw)
In-Reply-To: <Z-hsTSiAyyV3cBoE@bombadil.infradead.org>
On Sat, Mar 29, 2025 at 02:55:27PM -0700, Luis Chamberlain wrote:
> On Tue, Mar 25, 2025 at 03:53:09PM +0100, Daniel Gomez wrote:
> > Shall we ensure that the pool folder is created with group write permissions?
>
> Yes.
>
> That's a needed fix in this series.
I'll replace the verify check for system session with just these two
tasks way above:
- name: Create storage pool path directory if using libvirt session URI
file:
path: "{{ libvirt_storage_pool_path }}"
state: directory
mode: "0775"
when: libvirt_use_session_uri | default(false) | bool
tags:
- vars
- name: Create storage pool path directory and set group if using libvirt system URI
file:
path: "{{ libvirt_storage_pool_path }}"
state: directory
owner: root
group: "{{ libvirt_qemu_group }}"
mode: "0775"
when: not libvirt_use_session_uri | default(false) | bool
tags:
- vars
next prev parent reply other threads:[~2025-03-29 22:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-23 11:50 [PATCH 0/6] debian / libvirt / devconfig fixes Luis Chamberlain
2025-03-23 11:50 ` [PATCH 1/6] scripts/bringup_guestfs.sh: uninstall unattended-upgrades on debian guests Luis Chamberlain
2025-03-23 11:50 ` [PATCH 2/6] devconfig: ensure unattended-upgrades is not installed on debian Luis Chamberlain
2025-03-23 11:50 ` [PATCH 3/6] libvirt: use consistent pool path variables and use optional yaml output Luis Chamberlain
2025-03-23 11:50 ` [PATCH 4/6] Kconfig: adopt output yaml for KDEVOPS_FIRST_RUN Luis Chamberlain
2025-03-23 11:50 ` [PATCH 5/6] guestfs: add ansible group permisison check on libvirt system uri Luis Chamberlain
2025-03-25 14:53 ` Daniel Gomez
2025-03-29 21:55 ` Luis Chamberlain
2025-03-29 22:43 ` Luis Chamberlain [this message]
2025-03-29 22:55 ` Luis Chamberlain
2025-03-23 11:50 ` [PATCH 6/6] gen_nodes: ensure kdevops prefix has no dashes Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-h3eTCpRC28eaCm@bombadil.infradead.org \
--to=mcgrof@kernel.org \
--cc=da.gomez@kernel.org \
--cc=kdevops@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.