From: Patrick Steinhardt <ps@pks.im>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: chriscool@tuxfamily.org, git@vger.kernel.org, jltobler@gmail.com,
gitster@pobox.com, phillip.wood123@gmail.com,
sunshine@sunshineco.com, Toon Claes <toon@iotcl.com>
Subject: Re: [PATCH v4] blame: print unblamable and ignored commits in porcelain mode
Date: Mon, 31 Mar 2025 09:05:22 +0200 [thread overview]
Message-ID: <Z-o-suJAfu5yc2AW@pks.im> (raw)
In-Reply-To: <20250330204339.191382-1-karthik.188@gmail.com>
On Sun, Mar 30, 2025 at 10:43:39PM +0200, Karthik Nayak wrote:
> diff --git a/t/t8013-blame-ignore-revs.sh b/t/t8013-blame-ignore-revs.sh
> index 370b768149..50a0a7ca4a 100755
> --- a/t/t8013-blame-ignore-revs.sh
> +++ b/t/t8013-blame-ignore-revs.sh
> @@ -158,6 +158,21 @@ test_expect_success mark_unblamable_lines '
> test_cmp expect actual
> '
>
> +for opt in --porcelain --line-porcelain
> +do
> + test_expect_success "mark_unblamable_lines with $opt" '
> + sha=$(git rev-parse Y) &&
> +
> + git -c blame.markUnblamableLines=false blame $opt --ignore-rev Y file >raw &&
> + sed -e "s/^\ty3/unblamable\n&/" raw >expect &&
> + cp expect raw &&
> + sed -e "s/^\ty4/unblamable\n&/" raw >expect &&
The intent here is to do two replacements in "raw", right? You can do
this with a single call to sed(1) by chaining "-e":
git -c blame.markUnblamableLines=false blame $opt --ignore-rev Y file >raw &&
sed -e "s/^\ty3/unblamable\n&/" \
-e "s/^\ty4/unblamable\n&/" raw >expect &&
Patrick
next prev parent reply other threads:[~2025-03-31 7:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 16:39 [PATCH] blame: fix unblamable and ignored lines in porcelain mode Karthik Nayak
2025-03-23 15:58 ` Junio C Hamano
2025-03-24 10:16 ` Patrick Steinhardt
2025-03-24 10:37 ` Toon Claes
2025-03-24 20:04 ` Karthik Nayak
2025-03-25 8:45 ` Toon Claes
2025-03-25 10:31 ` Karthik Nayak
2025-03-25 19:44 ` Junio C Hamano
2025-03-24 20:00 ` Karthik Nayak
2025-03-24 19:56 ` Karthik Nayak
2025-03-26 21:06 ` [PATCH v2] blame: print unblamable and ignored commits " Karthik Nayak
2025-03-26 22:49 ` Eric Sunshine
2025-03-27 11:07 ` Karthik Nayak
2025-03-29 19:06 ` Junio C Hamano
2025-03-28 7:00 ` Patrick Steinhardt
2025-03-29 10:26 ` Karthik Nayak
2025-03-29 18:21 ` [PATCH v3] " Karthik Nayak
2025-03-30 4:56 ` Junio C Hamano
2025-03-30 9:28 ` Phillip Wood
2025-03-30 20:43 ` [PATCH v4] " Karthik Nayak
2025-03-31 7:05 ` Patrick Steinhardt [this message]
2025-03-31 7:34 ` Karthik Nayak
2025-03-31 10:24 ` phillip.wood123
2025-03-31 10:47 ` Phillip Wood
[not found] ` <CAOLa=ZSQ7PiasRk23Hxp7Gk5vU-x83N4e4WTxG3eVsxK0zKnWA@mail.gmail.com>
[not found] ` <f39c6468-aade-489a-bc7b-c3d342a22cb8@gmail.com>
[not found] ` <CAOLa=ZQMYn2eYndX0saTKnuzAacjtNZeTb9PCrcNC50nneAq5g@mail.gmail.com>
2025-04-02 13:07 ` Phillip Wood
2025-04-03 16:03 ` [PATCH v5] " Karthik Nayak
2025-04-04 15:58 ` Phillip Wood
2025-04-08 0:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-o-suJAfu5yc2AW@pks.im \
--to=ps@pks.im \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=karthik.188@gmail.com \
--cc=phillip.wood123@gmail.com \
--cc=sunshine@sunshineco.com \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.