From: Patrick Steinhardt <ps@pks.im>
To: Usman Akinyemi <usmanakinyemi202@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
gitster@pobox.com, johncai86@gmail.com, me@ttaylorr.com,
shejialuo@gmail.com, philip@example.com,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 1/1] builtin/update-server-info: remove unnecessary if statement
Date: Mon, 31 Mar 2025 09:16:44 +0200 [thread overview]
Message-ID: <Z-pBXOxmtJu9a9R4@pks.im> (raw)
In-Reply-To: <20250329120327.105925-2-usmanakinyemi202@gmail.com>
On Sat, Mar 29, 2025 at 05:29:25PM +0530, Usman Akinyemi wrote:
> Since we already teach the `repo_config()` to allow `repo`
> to be NULL, no need to check if `repo` is NULL before calling
> `repo_config()`.
Tiny nit: when you refer to changes made in a previous commit it makes
sense to reference that commit via `git log -1 --format=reference` so
that outside readers who aren't deeply familiar with the recent changes
know where to look.
Other than that this patch looks good to me, thanks!
Patrick
next prev parent reply other threads:[~2025-03-31 7:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 11:59 [PATCH 0/1] remove unnecessary if statement Usman Akinyemi
2025-03-29 11:59 ` [PATCH 1/1] builtin/update-server-info: " Usman Akinyemi
2025-03-31 7:16 ` Patrick Steinhardt [this message]
2025-04-06 12:14 ` [PATCH v2 0/1] " Usman Akinyemi
2025-04-06 12:14 ` [PATCH v2 1/1] builtin/update-server-info: " Usman Akinyemi
2025-04-07 0:24 ` Eric Sunshine
2025-04-07 15:49 ` Junio C Hamano
2025-04-07 19:58 ` [PATCH v2 0/1] " Usman Akinyemi
2025-04-07 19:58 ` [PATCH 1/1] builtin/update-server-info: " Usman Akinyemi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-pBXOxmtJu9a9R4@pks.im \
--to=ps@pks.im \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johncai86@gmail.com \
--cc=me@ttaylorr.com \
--cc=philip@example.com \
--cc=shejialuo@gmail.com \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.