From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Christian Hewitt <christianshewitt@gmail.com>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Peter Rosin" <peda@axentia.se>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: si2168: increase cmd execution timeout value
Date: Mon, 31 Mar 2025 10:34:33 +0200 [thread overview]
Message-ID: <Z-pTmaRpf_FUAlkk@shikoro> (raw)
In-Reply-To: <0073F061-994E-4DE6-AC0E-E7E03DD30275@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
On Mon, Mar 31, 2025 at 12:31:48PM +0400, Christian Hewitt wrote:
> > On 31 Mar 2025, at 12:06 pm, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> >
> >
> >> if (cmd->rlen) {
> >> /* wait cmd execution terminate */
> >> - #define TIMEOUT 70
> >> + #define TIMEOUT 200
> >
> > While we are here, can we rename it to CMD_TIMEOUT and put it next to
> > the #includes?
>
> I’m at the novice end of kernel contributors, so like this?
Exactly! Thank you. If you send v2 of this patch, you can already add:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-03-31 8:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 7:58 [PATCH] media: si2168: increase cmd execution timeout value Christian Hewitt
2025-03-31 8:06 ` Wolfram Sang
2025-03-31 8:31 ` Christian Hewitt
2025-03-31 8:34 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-pTmaRpf_FUAlkk@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=christianshewitt@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peda@axentia.se \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.