From: Gregory Price <gourry@gourry.net>
To: dan.j.williams@intel.com
Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
kernel-team@meta.com, dan.j.williams@intel.com,
vishal.l.verma@intel.com, dave.jiang@intel.com,
linux-cxl@vger.kernel.org, david@redhat.com
Subject: Re: [PATCH] DAX: warn when kmem regions are truncated for memory block alignment.
Date: Mon, 31 Mar 2025 14:27:36 -0400 [thread overview]
Message-ID: <Z-remBNWEej6KX3-@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <20250321180731.568460-1-gourry@gourry.net>
On Fri, Mar 21, 2025 at 02:07:31PM -0400, Gregory Price wrote:
> Device capacity intended for use as system ram should be aligned to the
> architecture-defined memory block size or that capacity will be silently
> truncated and capacity stranded.
>
> As hotplug dax memory becomes more prevelant, the memory block size
> alignment becomes more important for platform and device vendors to
> pay attention to - so this truncation should not be silent.
>
> This issue is particularly relevant for CXL Dynamic Capacity devices,
> whose capacity may arrive in spec-aligned but block-misaligned chunks.
>
> Example:
> [...] kmem dax0.0: dax region truncated 2684354560 bytes - alignment
> [...] kmem dax1.0: dax region truncated 1610612736 bytes - alignment
>
> Signed-off-by: Gregory Price <gourry@gourry.net>
Gentle pokes. There were a couple questions last week whether we should
warn here or actually fix something in memory-hotplug.
Notes from CXL Boot to Bash session discussions:
We discussed [1] how this auto-sizing can cause 1GB huge page
allocation failures (assuming you online as ZONE_NORMAL). That means
ACPI-informed sizing by default would potentially be harmful to existing
systems and adding yet-another-boot-option just seems nasty.
I've since dropped acpi-informed block size patch[2]. If there are opinions
otherwise, I can continue pushing it.
We also discussed[3] variable-sized blocks having some nasty corner cases.
Not unsolvable, but doesn't help users in the short term.
There was some brief discussion about whether a hotplug memblock with a
portion as offline pages would be possible. This seems hacky? There
was another patch set discussing this, but I can't seem to find it.
I debated whether to warn here or in ACPI. This seemed more accurate,
as platforms could simply over-reserve HPA space to avoid the issue.
Thoughts?
~Gregory
[1] https://lore.kernel.org/all/bda4cf52-d81a-4935-b45a-09e9439e33b6@redhat.com/
[2] https://lore.kernel.org/linux-mm/20250127153405.3379117-1-gourry@gourry.net/
[3]https://lore.kernel.org/all/b4b312c8-1117-45cd-a3c3-c8747aca51bd@redhat.com/
next prev parent reply other threads:[~2025-03-31 18:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 18:07 [PATCH] DAX: warn when kmem regions are truncated for memory block alignment Gregory Price
2025-03-31 18:27 ` Gregory Price [this message]
2025-04-01 9:33 ` David Hildenbrand
2025-04-01 14:43 ` Gregory Price
2025-04-01 14:50 ` David Hildenbrand
2025-04-01 15:16 ` Gregory Price
2025-04-01 15:19 ` David Hildenbrand
2025-04-01 15:26 ` Gregory Price
2025-04-01 15:29 ` David Hildenbrand
2025-04-01 9:47 ` David Hildenbrand
2025-04-01 14:44 ` Gregory Price
2025-04-01 17:47 ` Dan Williams
2025-04-01 18:27 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-remBNWEej6KX3-@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=kernel-team@meta.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.