From: Dave Chinner <david@fromorbit.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: "Andrey Albershteyn" <aalbersh@redhat.com>,
"Pali Rohár" <pali@kernel.org>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH 1/2] fs: prepare for extending [gs]etfsxattrat()
Date: Tue, 1 Apr 2025 07:58:01 +1100 [thread overview]
Message-ID: <Z-sB2XYNlEl0u7j0@dread.disaster.area> (raw)
In-Reply-To: <20250329143312.1350603-2-amir73il@gmail.com>
On Sat, Mar 29, 2025 at 03:33:11PM +0100, Amir Goldstein wrote:
> We intend to add support for more xflags to selective filesystems and
> We cannot rely on copy_struct_from_user() to detect this extention.
>
> In preparation of extending the API, do not allow setting xflags unknown
> by this kernel version.
>
> Also do not pass the read-only flags and read-only field fsx_nextents to
> filesystem.
>
> These changes should not affect existing chattr programs that use the
> ioctl to get fsxattr before setting the new values.
.....
> +
> +#define FS_XFALGS_MASK \
> + (FS_XFLAG_COMMON | FS_XFLAG_RDONLY_MASK | FS_XFLAG_VALUES_MASK | \
> + FS_XFLAG_DIRONLY_MASK | FS_XFLAG_MISC_MASK)
You might want to fix the obvious typo....
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2025-03-31 20:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-29 14:33 [RFC PATCH 0/2] [gs]etfsxattrat() followup patches Amir Goldstein
2025-03-29 14:33 ` [RFC PATCH 1/2] fs: prepare for extending [gs]etfsxattrat() Amir Goldstein
2025-03-31 14:43 ` Andrey Albershteyn
2025-03-31 15:06 ` Amir Goldstein
2025-03-31 20:58 ` Dave Chinner [this message]
2025-03-29 14:33 ` [RFC PATCH 2/2] fs: add support for custom fsx_xflags_mask Amir Goldstein
2025-03-29 14:43 ` Amir Goldstein
2025-03-29 14:44 ` Pali Rohár
2025-03-29 15:23 ` Amir Goldstein
2025-04-01 10:45 ` [RFC PATCH 0/2] [gs]etfsxattrat() followup patches Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-sB2XYNlEl0u7j0@dread.disaster.area \
--to=david@fromorbit.com \
--cc=aalbersh@redhat.com \
--cc=amir73il@gmail.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.