All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Tiezhu Yang <yangtiezhu@loongson.cn>,
	kernel test robot <lkp@intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 08/11] objtool/loongarch: Add unwind hints in prepare_frametrace()
Date: Tue, 1 Apr 2025 09:08:28 +0200	[thread overview]
Message-ID: <Z-uQ7NqMzqAShWcH@gmail.com> (raw)
In-Reply-To: <270cadd8040dda74db2307f23497bb68e65db98d.1743481539.git.jpoimboe@kernel.org>


* Josh Poimboeuf <jpoimboe@kernel.org> wrote:

> If 'regs' points to a local stack variable, prepare_frametrace() stores
> all registers to the stack.  This confuses objtool as it expects them to
> be restored from the stack later.
> 
> The stores don't affect stack tracing, so use unwind hints to hide them
> from objtool.
> 
> Fixes the following warnings:
> 
>   arch/loongarch/kernel/traps.o: warning: objtool: show_stack+0xe0: stack state mismatch: reg1[22]=-1+0 reg2[22]=-2-160
>   arch/loongarch/kernel/traps.o: warning: objtool: show_stack+0xe0: stack state mismatch: reg1[23]=-1+0 reg2[23]=-2-152
> 
> Cc: Tiezhu Yang <yangtiezhu@loongson.cn>
> Fixes: cb8a2ef0848c ("LoongArch: Add ORC stack unwinder support")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503280703.OARM8SrY-lkp@intel.com/
> Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>

Note, I skipped this fix from tip:objtool/urgent for the time being, 
because Tiezhu Yang indicated that he'd be reviewing and testing this 
patch.

Thanks,

	Ingo

  reply	other threads:[~2025-04-01  7:08 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01  4:26 [PATCH 00/11] Yet more objtool fixes Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 01/11] objtool: Silence more KCOV warnings, part 2 Josh Poimboeuf
2025-04-01  7:15   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 02/11] objtool: Ignore end-of-section jumps for KCOV/GCOV Josh Poimboeuf
2025-04-01  7:15   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 03/11] objtool: Append "()" to function name in "unexpected end of section" warning Josh Poimboeuf
2025-04-01  7:15   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 04/11] Revert "objtool: Increase per-function WARN_FUNC() rate limit" Josh Poimboeuf
2025-04-01  7:15   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 05/11] objtool: Always fail on fatal errors Josh Poimboeuf
2025-04-01  7:15   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 06/11] objtool: Change "warning:" to "error:" for " Josh Poimboeuf
2025-04-01  7:15   ` [tip: objtool/urgent] objtool: Change "warning:" to "error: " " tip-bot2 for Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 07/11] objtool: Fix verbose disassembly if CROSS_COMPILE isn't set Josh Poimboeuf
2025-04-01  7:15   ` [tip: objtool/urgent] " tip-bot2 for David Laight
2025-04-01  4:26 ` [PATCH 08/11] objtool/loongarch: Add unwind hints in prepare_frametrace() Josh Poimboeuf
2025-04-01  7:08   ` Ingo Molnar [this message]
2025-04-01  7:45     ` Tiezhu Yang
2025-04-01  8:10       ` Ingo Molnar
2025-04-01  8:29         ` Tiezhu Yang
2025-04-01  8:17   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 09/11] sched/smt: Always inline sched_smt_active() Josh Poimboeuf
2025-04-01  7:15   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 10/11] context_tracking: Always inline ct_{nmi,irq}_{enter,exit}() Josh Poimboeuf
2025-04-01  7:15   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-01  7:26   ` tip-bot2 for Josh Poimboeuf
2025-04-01  4:26 ` [PATCH 11/11] rcu-tasks: Always inline rcu_irq_work_resched() Josh Poimboeuf
2025-04-01  7:14   ` [tip: objtool/urgent] " tip-bot2 for Josh Poimboeuf
2025-04-01  7:26   ` tip-bot2 for Josh Poimboeuf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-uQ7NqMzqAShWcH@gmail.com \
    --to=mingo@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=peterz@infradead.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.