From: Daniel Thompson <danielt@kernel.org>
To: Henry Martin <bsdhenrymartin@gmail.com>
Cc: lee@kernel.org, jingoohan1@gmail.com, deller@gmx.de,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v3] backlight: pm8941: Add NULL check in wled_configure()
Date: Tue, 1 Apr 2025 09:44:51 +0100 [thread overview]
Message-ID: <Z-ung-_3ErYHqnXU@aspen.lan> (raw)
In-Reply-To: <20250401025737.16753-1-bsdhenrymartin@gmail.com>
On Tue, Apr 01, 2025 at 10:57:37AM +0800, Henry Martin wrote:
> devm_kasprintf() returns NULL when memory allocation fails. Currently,
> wled_configure() does not check for this case, which results in a NULL
> pointer dereference.
>
> Add NULL check after devm_kasprintf() to prevent this issue.
>
> Fixes: f86b77583d88 ("backlight: pm8941: Convert to using %pOFn instead of device_node.name")
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Henry Martin <bsdhenrymartin@gmail.com>
Reviewed-by: Daniel Thompson (RISCstar) <danielt@kernel.org>
Daniel.
prev parent reply other threads:[~2025-04-01 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 2:57 [PATCH v3] backlight: pm8941: Add NULL check in wled_configure() Henry Martin
2025-04-01 6:18 ` Markus Elfring
2025-04-01 6:53 ` Henry Martin
2025-04-01 8:29 ` Henry Martin
2025-04-01 8:58 ` Daniel Thompson
2025-04-01 9:16 ` [PATCH v4] " Henry Martin
2025-04-04 15:11 ` (subset) " Lee Jones
2025-04-04 15:13 ` Lee Jones
2025-04-04 15:19 ` henry martin
2025-04-01 10:00 ` [v4?] " Markus Elfring
2025-04-01 8:44 ` Daniel Thompson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-ung-_3ErYHqnXU@aspen.lan \
--to=danielt@kernel.org \
--cc=bsdhenrymartin@gmail.com \
--cc=deller@gmx.de \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.