Re: [PATCH] mm: Rename vm_area_struct to mm_area

[Harry Yoo <harry.yoo@oracle.com>]

On Tue, Apr 01, 2025 at 04:21:53PM +0200, Vlastimil Babka wrote:
> On 4/1/25 16:17, Liam R. Howlett wrote:
> > * Matthew Wilcox (Oracle) <willy@infradead.org> [250401 08:26]:
> >> We don't need to put "_struct" on the end of the name.  It's obviously
> >> a struct.  Just look at the word "struct" before the name.  The acronym
> >> "vm" tends to mean "virtual machine" rather than "virtual memory" these
> >> days, so use "mm_area" instead of "vm_area".  I decided not to rename
> >> the variables (typically "vma") of type "struct mm_area *" as that would
> >> be a fair bit more disruptive.
> > 
> > I'm not sure I like this idea.  I mean, we should be more clear about
> > the type.  It's not even saying it is _in_ a struct.
> > 
> > Maybe we should go another direction and change vm_area_struct to
> > "memory_area_virtual_in_struct" to really clarify what we are talking
> > about.
> > 
> > Obviously the variables "vma" should be updated (over time, as code is
> > changed..) to "mavis" to match the new struct name, for type clarity -
> > like a beacon.  I really like the mavis beacon idea, it makes typing
> > easier.
> 
> I agree with this direction. We should also rename "struct address_space" to
> "struct address_space_struct" and rename folio.mapping accordingly.

I'm not sure if that abbrebation is complaint with the CoC. :P

> > Another added benefit to this naming convention is that the virtual
> > machine code is free to use "machine_address_under_virtual_enrichment".
> > This will will provide colour to the code, especially in the variable
> > names.
> > 
> > Thanks,
> > Liam

-- 
Cheers,
Harry (formerly known as Hyeonggon)