From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
To: Pavel Machek <pavel@denx.de>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Biju Das <biju.das.jz@bp.renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
tomm.merciai@gmail.com
Subject: Re: [PATCH 6.12.y-cip 05/13] pinctrl: renesas: rzg2l: Move RZG2L_SINGLE_PIN definition to top of the file
Date: Tue, 1 Apr 2025 12:38:21 +0200 [thread overview]
Message-ID: <Z-vCHQYcAsz_clJr@tom-desktop> (raw)
In-Reply-To: <Z+u/S2MaYNST5kNl@duo.ucw.cz>
Hi Pavel,
Thanks for your review.
On Tue, Apr 01, 2025 at 12:26:19PM +0200, Pavel Machek wrote:
> Hi!
>
> > commit 13dcd63dc704b33a8ad94f1d161c0f5dad243a5b upstream.
> >
> > Define `RZG2L_SINGLE_PIN` at the top of the file to clarify its use for
> > dedicated pins for improved readability.
> >
> > While at it update the comment for `RZG2L_SINGLE_PIN_PACK` macro and place
> > it just above the macro for clarity.
>
> Changelog no longer matches the patch.
>
> > diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > index 5081c7d8064fa..b47f0f1257cff 100644
> > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > @@ -65,6 +65,8 @@
> > #define RZG2L_SINGLE_PIN BIT_ULL(63) /* Dedicated pin */
> > #define RZG2L_VARIABLE_CFG BIT_ULL(62) /* Variable cfg for port pins */
> >
> > +#define RZG2L_SINGLE_PIN BIT_ULL(63) /* Dedicated pin */
> > +
>
> And the patch was already applied, see the previous defines. I believe
> we can just drop this one safely.
Agreed. I've done a test on my side.
We can just drop this one safely.
Thanks,
Tommaso
>
> Best regards,
> Pavel
> --
> DENX Software Engineering GmbH, Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2025-04-01 10:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 11:06 [PATCH 6.12.y-cip 00/13] Add RZ/G3E pinctrl support Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 01/13] dt-bindings: pinctrl: renesas: Add alpha-numerical port support for RZ/V2H Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 02/13] dt-bindings: pinctrl: renesas: Document RZ/V2H(P) SoC Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 03/13] dt-bindings: pinctrl: renesas,rzg2l-pinctrl: Allow schmitt and open drain properties Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 04/13] dt-bindings: pinctrl: renesas: Document RZ/G3E SoC Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 05/13] pinctrl: renesas: rzg2l: Move RZG2L_SINGLE_PIN definition to top of the file Tommaso Merciai
2025-04-01 10:26 ` Pavel Machek
2025-04-01 10:38 ` Tommaso Merciai [this message]
2025-03-31 11:06 ` [PATCH 6.12.y-cip 06/13] pinctrl: renesas: rzg2l: Remove RZG2L_TINT_IRQ_START_INDEX Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 07/13] pinctrl: renesas: rzg2l: Add support for enabling/disabling open-drain outputs Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 08/13] pinctrl: renesas: rzg2l: Add support for configuring schmitt-trigger Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 09/13] pinctrl: renesas: rzg2l: Use gpiochip_populate_parent_fwspec_twocell helper Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 10/13] pinctrl: renesas: rzg2l: Update r9a09g057_variable_pin_cfg table Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 11/13] pinctrl: renesas: rzg2l: Add support for RZ/G3E SoC Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 12/13] arm64: dts: renesas: r9a09g047: Add pincontrol node Tommaso Merciai
2025-03-31 11:06 ` [PATCH 6.12.y-cip 13/13] arm64: dts: renesas: r9a09g047e57-smarc: Add SCIF pincontrol Tommaso Merciai
2025-04-01 10:29 ` [PATCH 6.12.y-cip 00/13] Add RZ/G3E pinctrl support Pavel Machek
2025-04-01 10:40 ` Tommaso Merciai
2025-04-02 7:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-vCHQYcAsz_clJr@tom-desktop \
--to=tommaso.merciai.xr@bp.renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=pavel@denx.de \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=tomm.merciai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.