From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C9DFC36018 for ; Tue, 1 Apr 2025 13:02:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IfHLfQSnwvAHeNnWxeHzJN6mrHM1DRc3fPeIGWWk720=; b=CS+t2QWM3gCTTW 2lMNkLyuUmDGixbG2bmbrimwVciZySpQk8rDL21o8oDlRPO+fNQzsDJmlSstMWwoRFgq6iH0NnUEH wpqrnU/Xqb7FVxMt1GWZo/7s+m+fjaUgHF+ag9G4JMDkksNuJ1TdlrfUYjaOby4WhWtPjncEKP88k 2d9NiuJs2E4T3Xn4Aj4eGkq5xbk0echOXjseUQlrbvhVpvqBSCMjxYfvv4dwsQiR8SIwBAfsleEkG ingGQHc34n0jUuQgKGezu0LojI5OSjbyI7pbqNXQy65fxH9pVnjYTvxr+xXlJs3bmSr60gh/q0d/Z fk3RoMXr278M5KXd43bw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzbG5-00000003NkV-3MUh; Tue, 01 Apr 2025 13:02:25 +0000 Received: from mout01.posteo.de ([185.67.36.65]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzbDy-00000003NMi-0lhm for linux-amlogic@lists.infradead.org; Tue, 01 Apr 2025 13:00:15 +0000 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 80A60240028 for ; Tue, 1 Apr 2025 15:00:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1743512410; bh=DzC9bukHy47TjGfwcug8gM7evmzmuBLiRPZ4FYnSoOU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=LOKHmYAD92WGXRYddpx9klsLdIa724JsAZvgeQYdDVzxgFeVHQVircrF0Jg2GRDRO t20sTFLJqDPmw9155QtOZ1Q4Z1roVmL/RFOxMYkrif9+oqi6cMHJIWxu3N9+12bTtX 70ioAt5Wez9Fissvl4aWiIy1WpaNucvTzDkLqv4uwiGB2r22uKxDeZMHgdFo365xUD Z2oXanIvf0eGai3JG8orStMdKbhIoRk6CojNipN0QaP8u2o8XQENAmeJWpuaJ9Q53O 2RFwDOD5ESxHtEvKCG0gTnhG39w2EHSWkvM1LqPeHcPUkFXpapc09WOtwn4O75CtF0 Jmkng6GGUxR/g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4ZRp4m3h9Mz9rxQ; Tue, 1 Apr 2025 15:00:08 +0200 (CEST) Date: Tue, 1 Apr 2025 13:00:08 +0000 From: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= To: Martin Blumenstingl Cc: j.ne@posteo.net, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Kevin Hilman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 3/3] ARM: dts: amlogic: Add TCU Fernsehfee 3.0 Message-ID: References: <20250323-fernsehfee-v1-0-2621341cd37a@posteo.net> <20250323-fernsehfee-v1-3-2621341cd37a@posteo.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250401_060014_508609_617B7327 X-CRM114-Status: GOOD ( 25.54 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org T24gU3VuLCBNYXIgMzAsIDIwMjUgYXQgMTE6MTA6MjhQTSArMDIwMCwgTWFydGluIEJsdW1lbnN0 aW5nbCB3cm90ZToKPiBUaGFua3MgZm9yIHlvdXIgcGF0Y2ghCj4gCj4gT24gU3VuLCBNYXIgMjMs IDIwMjUgYXQgMTozOOKAr1BNIEouIE5ldXNjaMOkZmVyIHZpYSBCNCBSZWxheQo+IDxkZXZudWxs K2oubmUucG9zdGVvLm5ldEBrZXJuZWwub3JnPiB3cm90ZToKPiBbLi4uXQo+ID4gKyAgICAgICAg ICAgICAgIGV0aF9waHkwOiBldGhlcm5ldC1waHlAMCB7Cj4gPiArICAgICAgICAgICAgICAgICAg ICAgICAvKiBJQyBQbHVzIElQMTAxQSAoMHgwMjQzMGM1NCkgKi8KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgIHJlZyA9IDwwPjsKPiBEb2VzIHJlZyA9IDwxPiBhbHNvIHdvcmsgb24geW91ciBi b2FyZD8KPiAwIGlzIHRoZSBicm9hZGNhc3QgYWRkcmVzcy4gSXQncyB1bmZvcnR1bmF0ZWx5IHNv bWV0aGluZyB0aGF0IHdlIHN0aWxsCj4gaGF2ZSBpbmNvcnJlY3QgaW4gYSBsb3Qgb2YgLmR0cyBm aWxlcy4KClVuZm9ydHVuYXRlbHkgbm90LiBJIHRyaWVkIGFkZHJlc3NlcyAxIHRvIDMxIHdpdGhv dXQgc3VjY2Vzcywgd2hpY2gKc2VlbXMgc3RyYW5nZTsgbXkgZ3Vlc3Mgd2FzIHRoYXQgdGhlIFBI WSBzaG91bGQgcmVzcG9uZCB0byBvbmUgb2YgdGhlbS4KSSBnZXQgdGhpcyBlcnJvcjoKCiMgaXAg bCBzZXQgZXRoMCB1cApbICAgIDYuODA2ODQ3XSBtZXNvbjYtZHdtYWMgYzk0MTAwMDAuZXRoZXJu ZXQgZXRoMDogUmVnaXN0ZXIgTUVNX1RZUEVfUEFHRV9QT09MIFJ4US0wClsgICAgNi44MTA2MDld IG1lc29uNi1kd21hYyBjOTQxMDAwMC5ldGhlcm5ldCBldGgwOiBfX3N0bW1hY19vcGVuOiBDYW5u b3QgYXR0YWNoIHRvIFBIWSAoZXJyb3I6IC0xOSkKCgo+IAo+IFsuLi5dCj4gPiArJmkyY19BTyB7 Cj4gPiArICAgICAgIHN0YXR1cyA9ICJva2F5IjsKPiA+ICsgICAgICAgcGluY3RybC0wID0gPCZp MmNfYW9fcGlucz47Cj4gPiArICAgICAgIHBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cj4gPiAr Cj4gPiArICAgICAgIHBtaWNAMzIgewo+ID4gKyAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAi cmljb2gscm41dDYxOCI7Cj4gPiArICAgICAgICAgICAgICAgcmVnID0gPDB4MzI+Owo+ID4gKyAg ICAgICAgICAgICAgIHN5c3RlbS1wb3dlci1jb250cm9sbGVyOwo+IEhlcmUgSSdtIGEgYml0IHN1 cnByaXNlZDoKPiBBcmVuJ3Qgc29tZSBvZiB0aGUgb3V0cHV0cyB1c2VkIHRvIGRyaXZlIFZDQ0sg KENQVSBwb3dlciByYWlsKSBhbmQKPiBWRERFRSAoZXZlcnl0aGluZyBlbHNlIHBvd2VyIHJhaWws IHdoaWNoIGFsc28gcG93ZXJzIHRoZSBHUFUpPwoKVW5mb3J0dW5hdGVseSBJIGRvbid0IGhhdmUg c2NoZW1hdGljcyBhbmQgSSB3YXNuJ3QgYWJsZSB0byB0cmFjZSB0aGUKY29ubmVjdGlvbnMgb24g dGhlIGJvYXJkIGJlY2F1c2UgdGhleSdyZSBzbyB0aW55LiBTbyBpdCdzIHF1aXRlIHBvc3NpYmxl IHRoYXQKeW91J3JlIHJpZ2h0LCBidXQgSSBjYW4ndCBiZSBzdXJlLgoKQXJlIHRoZXJlIHZvbHRh Z2Ugc2Vuc29ycyBpbiB0aGUgTWVzb244IFNvQyB0aGF0IEkgY291bGQgdXNlIHRvIGVzdGFibGlz aHMgdGhlCnJlbGF0aW9uIGJldHdlZW4gUE1JQyBvdXRwdXRzIGFuZCBTb0Mgc3VwcGxpZXM/Cgo+ IAo+IFsuLi5dCj4gPiArJnVzYjEgewo+ID4gKyAgICAgICBzdGF0dXMgPSAib2theSI7Cj4gPiAr ICAgICAgIGRyX21vZGUgPSAiaG9zdCI7Cj4gPiArICAgICAgIC8qCj4gPiArICAgICAgICAqIFRo aXMgYnVzIGZlYXR1cmVzIGEgUmVhbHRlayBSVEw4MTg4IDIuNEdIeiBXaUZpIG1vZHVsZSwgd2l0 aCBhCj4gPiArICAgICAgICAqIDMuM1Ygc3VwcGx5IHZvbHRhZ2UgdGhhdCBtdXN0IGJlIGVuYWJs ZWQgYmVmb3JlIHVzZS4KPiA+ICsgICAgICAgICovCj4gPiArICAgICAgIHZidXMtc3VwcGx5ID0g PCZ3aWZpXzN2Mz47Cj4gSWYgeW91IHdhbnQgdG8gZ28gZm9yIHBlcmZlY3Rpb24gdGhlbiB5b3Ug Y2FuIHVzZQo+IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC94bW9zLHh2 ZjM1MDAueWFtbCBhcwo+IHJlZmVyZW5jZS4KPiBJdCdzIGFsc28gYW4gIm9uYm9hcmQiIFVTQiBk ZXZpY2Ugd2hpY2ggcmVxdWlyZXMgdG9nZ2xpbmcgYSBHUElPIGFuZCByZWd1bGF0b3JzLgo+IFRo ZSBkcml2ZXIgc2lkZSBpcyBzdXBlciBlYXN5IHRvIG1hbmFnZSBhcyBpdCdzIGdlbmVyaWMgKG1l YW5pbmc6IGl0Cj4gcGFyc2VzIGFueSBHUElPIGFuZCByZWd1bGF0b3IgYXMgbG9uZyBhcyB0aGUg VVNCIElEIGlzIHJlZ2lzdGVyZWQpOgo+IGRyaXZlcnMvdXNiL21pc2Mvb25ib2FyZF91c2JfZGV2 LmMKCkkgY29uc2lkZXJlZCB1c2luZyBvbmJvYXJkX3VzYl9kZXYsIGJ1dCB0aGVuIGNhbWUgdG8g dGhlIGNvbmNsdXNpb24gdGhhdApJIGRvbid0IG5lZWQgaXQgYmVjYXVzZSBJIGRvbid0IG5lZWQg cmVzZXQgc2VxdWVuY2luZywgb25seSBwb3dlci4KCj4gVGhhdCB3YXkgeW91IGNhbiBqdXN0IGRl c2NyaWJlIHRoZSBSVEw4MTg4IG9uIHRoZSBVU0IgYnVzIGFuZCBhc3NpZ24KPiBpdCdzIHZkMzMt c3VwcGx5IHdpdGhvdXQgaGF2aW5nIHRvIChhYil1c2UgdmJ1cy1zdXBwbHkgb2YgdGhlIFVTQgo+ IGNvbnRyb2xsZXIuCgpUaGlzIGRvZXMgc291bmQgcmVhc29uYWJsZS4gSSdsbCByZWNvbnNpZGVy IHRoZSBvbmJvYXJkX3VzYl9kZXYKYXBwcm9hY2guCgo+IAo+IFsuLi5dCj4gPiArICAgICAgICAg ICAgICAgc2R4Y19jX3BpbnM6IHNkeGMtYyB7Cj4gPiArICAgICAgICAgICAgICAgICAgICAgICBt dXggewo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBncm91cHMgPSAic2R4Y19k MF9jIiwgInNkeGNfZDEzX2MiLAo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICJzZHhjX2Nsa19jIiwgInNkeGNfY21kX2MiLAo+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJzZHhjX2Q0N19jIjsKPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZnVuY3Rpb24gPSAic2R4Y19jIjsKPiA+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYmlhc19wdWxsX3VwOwo+IFRoaXMgaGFzIHRvIGJlIGJpYXMtcHVsbC11 cCAoZGFzaGVzIGluc3RlYWQgb2YgdW5kZXJzY29yZXMpLgoKT2gsIGdvb2QgY2F0Y2gsIEknbGwg Zml4IGl0LgoKClRoYW5rcyBmb3IgeW91ciByZXZpZXcsCkouIE5ldXNjaMOkZmVyCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1h aWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FFE6C36010 for ; Tue, 1 Apr 2025 13:04:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rQWW+6GJT6SMKoyIQM+lsAzbcfqDVW6okh5ggmHwFxw=; b=yezJh7LELNE7R3OQkQu9Ja8Fu/ 6eYQL9RJgOod0mdfVZ+WpepqWd/nECoB8d4ICwzBoAWF9UMJIcsOANztgmWwCwvIl33qRBVB2D/Gc IWOB7IV6FOK1Hlvwp6jlwX0VqCAei5jngL6TOkoH4Bb6fddNexQtxWJWreBv9MgnfO6rrhh0zTPOk ZLdGwGky4vu8UUE12+m3hTnkmWFZJsoMW6sysdWQh+M4i8L7Y5P58xOJJPXy7H2xG0dqIhdB5wgSY 0vqeYPC/tUwiMpRrRc+TPLAGGEv6Ezavl6TRCpCtPaP1LDrClF3ziOcWqZNPD0H3BGdAw2bIobsM1 BqEIyElQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzbHq-00000003O6F-2ofU; Tue, 01 Apr 2025 13:04:14 +0000 Received: from mout01.posteo.de ([185.67.36.65]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1tzbDy-00000003NMk-1zOU for linux-arm-kernel@lists.infradead.org; Tue, 01 Apr 2025 13:00:16 +0000 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 1F677240027 for ; Tue, 1 Apr 2025 15:00:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1743512411; bh=DzC9bukHy47TjGfwcug8gM7evmzmuBLiRPZ4FYnSoOU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:Content-Transfer-Encoding:From; b=KcC27z+1Skglm25OKuxiO3aOVwBu6LWCxDrTfL+KZIo8jba2WPpMRawGb9xp64Dln qR9PDCvt+D+n3cl4DtMMdMVJOrm4rsKsiKEbwMdahVXMWUQwzX7M6oE7cbUf7e8iYh q4iiLzaGNEEdU/D3UjDqEnFJaLYg7BszvhgTpr+/xSPm9wBuWo2jWbQkwCEnSQwBy6 iucE2U9GlxFByRzTiiE3PS1pIIpLMP7nzb5kwLkctiehJz8QWGb3xRvQwxh+Q7oh7K KArnw9Vs7jEF9PhLby0MEcGoVnw7Kij4BF6Ck+dLRwsIxSLYOg6/d0/xBnwX5dKiYM zVWbhBGaKMwoA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4ZRp4m3h9Mz9rxQ; Tue, 1 Apr 2025 15:00:08 +0200 (CEST) Date: Tue, 1 Apr 2025 13:00:08 +0000 From: =?utf-8?Q?J=2E_Neusch=C3=A4fer?= To: Martin Blumenstingl Cc: j.ne@posteo.net, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Neil Armstrong , Jerome Brunet , Kevin Hilman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH 3/3] ARM: dts: amlogic: Add TCU Fernsehfee 3.0 Message-ID: References: <20250323-fernsehfee-v1-0-2621341cd37a@posteo.net> <20250323-fernsehfee-v1-3-2621341cd37a@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250401_060014_784962_9446F698 X-CRM114-Status: GOOD ( 26.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Mar 30, 2025 at 11:10:28PM +0200, Martin Blumenstingl wrote: > Thanks for your patch! > > On Sun, Mar 23, 2025 at 1:38 PM J. Neuschäfer via B4 Relay > wrote: > [...] > > + eth_phy0: ethernet-phy@0 { > > + /* IC Plus IP101A (0x02430c54) */ > > + reg = <0>; > Does reg = <1> also work on your board? > 0 is the broadcast address. It's unfortunately something that we still > have incorrect in a lot of .dts files. Unfortunately not. I tried addresses 1 to 31 without success, which seems strange; my guess was that the PHY should respond to one of them. I get this error: # ip l set eth0 up [ 6.806847] meson6-dwmac c9410000.ethernet eth0: Register MEM_TYPE_PAGE_POOL RxQ-0 [ 6.810609] meson6-dwmac c9410000.ethernet eth0: __stmmac_open: Cannot attach to PHY (error: -19) > > [...] > > +&i2c_AO { > > + status = "okay"; > > + pinctrl-0 = <&i2c_ao_pins>; > > + pinctrl-names = "default"; > > + > > + pmic@32 { > > + compatible = "ricoh,rn5t618"; > > + reg = <0x32>; > > + system-power-controller; > Here I'm a bit surprised: > Aren't some of the outputs used to drive VCCK (CPU power rail) and > VDDEE (everything else power rail, which also powers the GPU)? Unfortunately I don't have schematics and I wasn't able to trace the connections on the board because they're so tiny. So it's quite possible that you're right, but I can't be sure. Are there voltage sensors in the Meson8 SoC that I could use to establishs the relation between PMIC outputs and SoC supplies? > > [...] > > +&usb1 { > > + status = "okay"; > > + dr_mode = "host"; > > + /* > > + * This bus features a Realtek RTL8188 2.4GHz WiFi module, with a > > + * 3.3V supply voltage that must be enabled before use. > > + */ > > + vbus-supply = <&wifi_3v3>; > If you want to go for perfection then you can use > Documentation/devicetree/bindings/sound/xmos,xvf3500.yaml as > reference. > It's also an "onboard" USB device which requires toggling a GPIO and regulators. > The driver side is super easy to manage as it's generic (meaning: it > parses any GPIO and regulator as long as the USB ID is registered): > drivers/usb/misc/onboard_usb_dev.c I considered using onboard_usb_dev, but then came to the conclusion that I don't need it because I don't need reset sequencing, only power. > That way you can just describe the RTL8188 on the USB bus and assign > it's vd33-supply without having to (ab)use vbus-supply of the USB > controller. This does sound reasonable. I'll reconsider the onboard_usb_dev approach. > > [...] > > + sdxc_c_pins: sdxc-c { > > + mux { > > + groups = "sdxc_d0_c", "sdxc_d13_c", > > + "sdxc_clk_c", "sdxc_cmd_c", > > + "sdxc_d47_c"; > > + function = "sdxc_c"; > > + bias_pull_up; > This has to be bias-pull-up (dashes instead of underscores). Oh, good catch, I'll fix it. Thanks for your review, J. Neuschäfer