Re: [PATCH v3 0/5] ipmi: bmc-sim improvements

[Corey Minyard <corey@minyard.net>]

On Wed, Apr 02, 2025 at 12:01:47AM +1000, Nicholas Piggin wrote:
> These little things came up when looking at behaviour of IPMI with
> the bmc-sim implementation running the ppc powernv machine, and
> trying to clean up error messages and missing features.

This all looks good to me.  Thanks to Philippe for reviewing, too.

I can give you an

Acked-by: Corey Minyard <cminyard@mvista.com>

if you are working on this for your own tree, or I can take it into
mine.

-corey

> 
> Since v1 (thanks to Corey for review and suggestions):
> - Added fwinfo to PCI devices
> - Report interrupt number in Get Channel Info for ISA, PCI, and
>   unknown/unassigned.
> - Fix error reporting for Get Channel Info unsupported channels.
>   Verify it is the correct error code that ipmitool looks for
>   https://github.com/ipmitool/ipmitool/blob/master/lib/ipmi_channel.c#L256C16-L256C45
> - Change _CH_ to _CHANNEL_ in some defines names.
> - Also avoid adding event logs with watchdog don't log flag.
> 
> Since v2:
> - Don't log watchog flag should not apply to watchdog expiry
>   field.
> - Moved protocol type field from class to IPMIFwInfo.
> - Rename new FwInfo member irq to irq_source.
> - Add comments about handling PCI devices to  existing callers
>   of ->fwinfo
> 
> Thanks,
> Nick
> 
> 
> Nicholas Piggin (5):
>   ipmi/pci-ipmi-bt: Rename copy-paste variables
>   ipmi: add fwinfo to pci ipmi devices
>   ipmi/bmc-sim: Add 'Get Channel Info' command
>   ipmi/bmc-sim: implement watchdog dont log flag
>   ipmi/bmc-sim: add error handling for 'Set BMC Global Enables' command
> 
>  include/hw/ipmi/ipmi.h     |  15 ++++++
>  hw/acpi/ipmi.c             |   3 +-
>  hw/ipmi/ipmi_bmc_sim.c     | 104 ++++++++++++++++++++++++++++++++-----
>  hw/ipmi/ipmi_bt.c          |   2 +
>  hw/ipmi/ipmi_kcs.c         |   1 +
>  hw/ipmi/isa_ipmi_bt.c      |   1 +
>  hw/ipmi/isa_ipmi_kcs.c     |   1 +
>  hw/ipmi/pci_ipmi_bt.c      |  50 +++++++++++-------
>  hw/ipmi/pci_ipmi_kcs.c     |  11 ++++
>  hw/smbios/smbios_type_38.c |   7 ++-
>  10 files changed, 162 insertions(+), 33 deletions(-)
> 
> -- 
> 2.47.1
>