From: Stanislav Fomichev <stfomichev@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
Stanislav Fomichev <sdf@fomichev.me>, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Simon Horman <horms@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
syzbot+08936936fe8132f91f1a@syzkaller.appspotmail.com
Subject: Re: [PATCH bpf] bpf: add missing ops lock around dev_xdp_attach_link
Date: Tue, 1 Apr 2025 09:39:08 -0700 [thread overview]
Message-ID: <Z-wWrMfsUtfrnMiU@mini-arch> (raw)
In-Reply-To: <CAADnVQJJFPD2X1enPCa-0D7RG6SraRFTdMj1bsKkzFuz6Nighw@mail.gmail.com>
On 04/01, Alexei Starovoitov wrote:
> On Tue, Apr 1, 2025 at 3:33 AM Paolo Abeni <pabeni@redhat.com> wrote:
> >
> > On 3/31/25 4:28 PM, Stanislav Fomichev wrote:
> > > Syzkaller points out that create_link path doesn't grab ops lock,
> > > add it.
> > >
> > > Cc: Jakub Kicinski <kuba@kernel.org>
> > > Reported-by: syzbot+08936936fe8132f91f1a@syzkaller.appspotmail.com
> > > Closes: https://lore.kernel.org/bpf/67e6b3e8.050a0220.2f068f.0079.GAE@google.com/
> > > Fixes: 97246d6d21c2 ("net: hold netdev instance lock during ndo_bpf")
> > > Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
> >
> > LGTM, but are there any special reasons to get this via the bpf tree? It
> > looks like 'net' material to me?!?
>
> Pls take it through net.
SG! LMK if I should repost to make it happen. (it's always hard for me,
with xdp, to figure out the proper tree)
next prev parent reply other threads:[~2025-04-01 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 14:28 [PATCH bpf] bpf: add missing ops lock around dev_xdp_attach_link Stanislav Fomichev
2025-04-01 10:33 ` Paolo Abeni
2025-04-01 15:05 ` Alexei Starovoitov
2025-04-01 16:39 ` Stanislav Fomichev [this message]
2025-04-02 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-wWrMfsUtfrnMiU@mini-arch \
--to=stfomichev@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=syzbot+08936936fe8132f91f1a@syzkaller.appspotmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.