All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Yan Zhao <yan.y.zhao@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Add a quirk to (not) honor guest PAT on CPUs that support self-snoop
Date: Tue, 1 Apr 2025 17:22:38 -0700	[thread overview]
Message-ID: <Z-yDTv-T4PTm9uHU@google.com> (raw)
In-Reply-To: <Z+yBGgoqv3dcgfg6@yzhao56-desk.sh.intel.com>

On Wed, Apr 02, 2025, Yan Zhao wrote:
> On Tue, Apr 01, 2025 at 03:11:07PM -0700, Sean Christopherson wrote:
> > Add back support for honoring guest PAT on Intel CPUs that support self-
> > snoop (and don't have errata), but guarded by a quirk so as not to break
> > existing setups that subtly relied on KVM forcing WB for synthetic
> > devices.
> > 
> > This effectively reverts commit 9d70f3fec14421e793ffbc0ec2f739b24e534900
> > and reapplies 377b2f359d1f71c75f8cc352b5c81f2210312d83, but with a quirk.
> > 
> > Cc: Yan Zhao <yan.y.zhao@intel.com>
> > Signed-off-by: Sean Christopherson <seanjc@google.com>
> > ---
> >
> Hi Sean,
> 
> > AFAIK, we don't have an answer as to whether the slow UC behavior on CLX+
> > is working as intended or a CPU flaw, which Paolo was hoping we would get
> We did answer the slow UC behavior is working as intended at [1].
> 
> "After consulting with CPU architects,
>  it's told that this behavior is expected on ICX/SPR Xeon platforms due to
>  the snooping implementation."
> 
> Paolo then help update the series to v2 [2] /v3 [3].
> 
> Did you overlook those series, or is there something I missed?

Nope, you didn't miss anything.  I have that series in my TODO folder, but only
glanced at it when it flew by and completely missed that it quirks ignoring
guest PAT.  Not sure how I missed the cover letter subject though...

Anyways, ignore this, my bad.  Thanks for the update, and sorry for the noise!

  reply	other threads:[~2025-04-02  0:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-01 22:11 [PATCH] KVM: VMX: Add a quirk to (not) honor guest PAT on CPUs that support self-snoop Sean Christopherson
2025-04-02  0:13 ` Yan Zhao
2025-04-02  0:22   ` Sean Christopherson [this message]
2025-04-02  1:09     ` Yan Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z-yDTv-T4PTm9uHU@google.com \
    --to=seanjc@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.