From: Nick <nick@kousu.ca>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Saket Dumbre <saket.dumbre@intel.com>,
Pawel Chmielewski <pawel.chmielewski@intel.com>,
Mario Limonciello <superm1@kernel.org>
Subject: Re: [PATCH v1 2/3] ACPI: button: Enable wakeup GPEs for ACPI buttons at probe time
Date: Thu, 21 May 2026 21:48:35 -0400 [thread overview]
Message-ID: <Z01FFT.NPPC3AQH2RI22@kousu.ca> (raw)
In-Reply-To: <2265993.irdbgypaU6@rafael.j.wysocki>
Hello Rafael,
On Thu, May 21 2026 at 03:38:50 PM +02:00:00, Rafael J. Wysocki
<rafael@kernel.org> wrote:
>
> Link:
> https://lore.kernel.org/linux-acpi/E2OXET.4X5GTP37VTNC3@kousu.ca/ [1]
> Fixes: 57c31e6d620f ("ACPI: scan: Use acpi_setup_gpe_for_wake() for
> buttons")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: 7.0+ <stable@vger.kernel.org> # 7.0+
> ---
>
> @Nick, I have reproduced the change of behavior introduced by commit
> 57c31e6d620f132dc on one of my systems, but not the function keys
> regression because they are handled differently here. This patch
> should restore the missing functionality on your machine, but I would
> appreciate some testing feedback.
I have applied this patch series on top of today's mainline
(8bc67e4db64aa727). It worked! My brightness keys and mute and
lidswitch are back. That's great. Thank you! Learning how to bisect was
a steep curve for me but everything after that has been a really easy
experience. Thank you for knowing this subsystem deeply.
- Nick
next prev parent reply other threads:[~2026-05-22 1:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 13:31 [PATCH v1 0/3] ACPI: button: Fixes related to GPE handling and probe error path Rafael J. Wysocki
2026-05-21 13:32 ` [PATCH v1 1/3] ACPI: button: Fix ACPI GPE handler leak during removal Rafael J. Wysocki
2026-05-21 13:52 ` Mario Limonciello
2026-05-21 13:38 ` [PATCH v1 2/3] ACPI: button: Enable wakeup GPEs for ACPI buttons at probe time Rafael J. Wysocki
2026-05-22 1:48 ` Nick [this message]
2026-05-22 12:25 ` Rafael J. Wysocki
2026-05-22 12:26 ` Rafael J. Wysocki
2026-05-21 13:39 ` [PATCH v1 3/3] ACPI: button: Add missing device class clearing on probe failures Rafael J. Wysocki
2026-05-21 13:53 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z01FFT.NPPC3AQH2RI22@kousu.ca \
--to=nick@kousu.ca \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pawel.chmielewski@intel.com \
--cc=rafael@kernel.org \
--cc=saket.dumbre@intel.com \
--cc=superm1@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.