From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E61B1E0DB3 for ; Mon, 2 Dec 2024 22:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733177259; cv=none; b=WkLT3FCZe/iDs1LpWWkc5Van/K73Hep1f3keTu6EnHsaEwObiXOysJEir6e2TF8OzEwWLkKqe/IQf+eOrnq7poPPQQViDcYMgQAt7FjJQwT2yMDd65SnRkt0tQ5LMnYysa6xf8Q0beFFU5wtti5+7tvyBcKnBT53CmmwAk0YAwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733177259; c=relaxed/simple; bh=aMgTNU2yQUgiORpUOLaG95XWh8lcGtVhKx2wlzXx0UI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ITqPiQkYi1Th+wBhm6ipoe8XEXPeKCGAO3mI+7+EQJCui+fEzkuHLfXW0V697/6SDWJ0FxpP034nI9mub32YLgEjSa1OchUUH0Zii57sR/0s/DMcFf92SRI0dZBZHn6scbDjUtT46HtpVYm6Hene+9lWb6Q+JabAytpTnrVDRMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=P/y1nxVs; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="P/y1nxVs" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DNZbvfSssXQBAkiV5QTgDDOLM6EYzMUfUsQTp9Qh59c=; b=P/y1nxVsQCqb6BHriX1MZF8U9a 818SykCwB5uibSFiEL2BRG36HPz12PcI7MYGuwd/WD+uUtYnw443MuvK2vKIOZT97kvCoMrE1v9PL yTkjZ56zl9bgaudh/WxpsLHQb7tBabUB5cHL4cIunL1cujspL9Kczr+Xdw0eBro0HIwyB9ByTMmaj /HB/Q5We/yeyjL/HSatP3N1cCgi3nLQQhIw4V3g3/jsHCEv5DRjZGodJJE4nGVUh8eXBPsmxouuRe 8JFq9jvxvY2KR+8SQ5teVspEdynY49lB8kVje7mRfh0MdAb+1gsYorFY99HwfFYNmAPaRhvpnznIH CA9whG8w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34274) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tIEZF-0000rO-2S; Mon, 02 Dec 2024 22:06:58 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1tIEZ6-0003v0-1J; Mon, 02 Dec 2024 22:06:48 +0000 Date: Mon, 2 Dec 2024 22:06:48 +0000 From: "Russell King (Oracle)" To: jan.petrous@oss.nxp.com Cc: Maxime Coquelin , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Vinod Koul , Richard Cochran , Andrew Lunn , Heiner Kallweit , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Emil Renner Berthing , Minda Chen , Nicolas Ferre , Claudiu Beznea , Iyappan Subramanian , Keyur Chudgar , Quan Nguyen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Giuseppe Cavallaro , Andrew Lunn , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, NXP S32 Linux Team , 0x1207@gmail.com, fancer.lancer@gmail.com, Jacob Keller Subject: Re: [PATCH net-next v7 01/15] net: driver: stmmac: Fix CSR divider comment Message-ID: References: <20241202-upstream_s32cc_gmac-v7-0-bc3e1f9f656e@oss.nxp.com> <20241202-upstream_s32cc_gmac-v7-1-bc3e1f9f656e@oss.nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241202-upstream_s32cc_gmac-v7-1-bc3e1f9f656e@oss.nxp.com> Sender: Russell King (Oracle) Hi, No need for "driver:" in the subject line. On Mon, Dec 02, 2024 at 11:03:40PM +0100, Jan Petrous via B4 Relay wrote: > From: "Jan Petrous (OSS)" > > The comment in declaration of STMMAC_CSR_250_300M > incorrectly describes the constant as '/* MDC = clk_scr_i/122 */' > but the DWC Ether QOS Handbook version 5.20a says it is > CSR clock/124. > > Signed-off-by: Jan Petrous (OSS) > Reviewed-by: Jacob Keller With that fixed, Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14CB7E69E99 for ; Mon, 2 Dec 2024 22:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DNZbvfSssXQBAkiV5QTgDDOLM6EYzMUfUsQTp9Qh59c=; b=b1HUzMwKDEkPpRp1W8h95CvA1u uj6wi8/T+NQbaH5JFZNkGZ5LS0m2WtGbRvnRlBrwJY+U3vu61VtiCcKwhBQ8akoxWjbiR4CiNyiOp BMbdOcPuYIRVtSl+uHBps1iJjGHf4IPaw3t4DVuTmKcOAi/dlv47zYhXy3WFDtpd6bLvRmKXi0lec q/hN6VaJyXV6FOj6tkSAKDvJJmnJJJMuKH21qq1P8hAZslW/Pp/Nvm1b0lkLcD7j/OyDQWhF/1Cs0 7jkxLcbhTG1xS2Q/avnp6I3VkAVdN+7/UU5O9snZOtUa6eOqn4kouM0IjshIWR1+ymPgUXI2zS1Gc XX/rsD9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tIEmZ-00000007cpH-3tc0; Mon, 02 Dec 2024 22:20:43 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tIEZq-00000007aSk-3ffg for linux-arm-kernel@lists.infradead.org; Mon, 02 Dec 2024 22:07:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=DNZbvfSssXQBAkiV5QTgDDOLM6EYzMUfUsQTp9Qh59c=; b=P/y1nxVsQCqb6BHriX1MZF8U9a 818SykCwB5uibSFiEL2BRG36HPz12PcI7MYGuwd/WD+uUtYnw443MuvK2vKIOZT97kvCoMrE1v9PL yTkjZ56zl9bgaudh/WxpsLHQb7tBabUB5cHL4cIunL1cujspL9Kczr+Xdw0eBro0HIwyB9ByTMmaj /HB/Q5We/yeyjL/HSatP3N1cCgi3nLQQhIw4V3g3/jsHCEv5DRjZGodJJE4nGVUh8eXBPsmxouuRe 8JFq9jvxvY2KR+8SQ5teVspEdynY49lB8kVje7mRfh0MdAb+1gsYorFY99HwfFYNmAPaRhvpnznIH CA9whG8w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34274) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tIEZF-0000rO-2S; Mon, 02 Dec 2024 22:06:58 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.96) (envelope-from ) id 1tIEZ6-0003v0-1J; Mon, 02 Dec 2024 22:06:48 +0000 Date: Mon, 2 Dec 2024 22:06:48 +0000 From: "Russell King (Oracle)" To: jan.petrous@oss.nxp.com Subject: Re: [PATCH net-next v7 01/15] net: driver: stmmac: Fix CSR divider comment Message-ID: References: <20241202-upstream_s32cc_gmac-v7-0-bc3e1f9f656e@oss.nxp.com> <20241202-upstream_s32cc_gmac-v7-1-bc3e1f9f656e@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241202-upstream_s32cc_gmac-v7-1-bc3e1f9f656e@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241202_140734_911761_0043A0A5 X-CRM114-Status: UNSURE ( 9.22 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , NXP S32 Linux Team , Emil Renner Berthing , imx@lists.linux.dev, Alexandre Torgue , Claudiu Beznea , Eric Dumazet , Iyappan Subramanian , Quan Nguyen , Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, Rob Herring , 0x1207@gmail.com, Jose Abreu , Jacob Keller , Jakub Kicinski , Paolo Abeni , Richard Cochran , devicetree@vger.kernel.org, Conor Dooley , Maxime Coquelin , linux-arm-msm@vger.kernel.org, Sascha Hauer , Keyur Chudgar , Minda Chen , Giuseppe Cavallaro , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, fancer.lancer@gmail.com, linux-kernel@vger.kernel.org, Andrew Lunn , Vinod Koul , Pengutronix Kernel Team , Krzysztof Kozlowski , Shawn Guo , "David S. Miller" , Heiner Kallweit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, No need for "driver:" in the subject line. On Mon, Dec 02, 2024 at 11:03:40PM +0100, Jan Petrous via B4 Relay wrote: > From: "Jan Petrous (OSS)" > > The comment in declaration of STMMAC_CSR_250_300M > incorrectly describes the constant as '/* MDC = clk_scr_i/122 */' > but the DWC Ether QOS Handbook version 5.20a says it is > CSR clock/124. > > Signed-off-by: Jan Petrous (OSS) > Reviewed-by: Jacob Keller With that fixed, Reviewed-by: Russell King (Oracle) Thanks! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!