From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A03A6D49797 for ; Tue, 3 Dec 2024 09:19:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIP3O-0004in-6z; Tue, 03 Dec 2024 04:18:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIP3M-0004iW-AW for qemu-devel@nongnu.org; Tue, 03 Dec 2024 04:18:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIP3J-000280-BX for qemu-devel@nongnu.org; Tue, 03 Dec 2024 04:18:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733217519; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3i4bTSe4R/89G2wOxNP6QDHdmwR5h8AAhSb0egWe4RI=; b=IjqHqvdjDtuFQOsrWOe0t6Wn29mxT3FF1uTIDXuakOnh3dWxCxmks9uoHNVseiQJmSOhsn WawVapxGYapW+VL9iNiJd72JDhKRiZwTy8jq6HiOhHEv4IhC0naP2LA+5Xt8xxAG9I+7AQ 5UbRjN/mxULxvuWtrwwZ5HLpneOF5IA= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-gStdD38mNfONw3xldMMKrw-1; Tue, 03 Dec 2024 04:18:35 -0500 X-MC-Unique: gStdD38mNfONw3xldMMKrw-1 X-Mimecast-MFC-AGG-ID: gStdD38mNfONw3xldMMKrw Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BB20B1944B2A; Tue, 3 Dec 2024 09:18:33 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.37]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 109D71956052; Tue, 3 Dec 2024 09:18:29 +0000 (UTC) Date: Tue, 3 Dec 2024 09:18:26 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Marcel Apfelbaum , Thomas Huth , Zhao Liu , Eduardo Habkost , Yanan Wang , Markus Armbruster Subject: Re: [PATCH-for-9.2? v2 1/2] tests/functional/test_version: Use QTest accelerator Message-ID: References: <20241203091036.59898-1-philmd@linaro.org> <20241203091036.59898-2-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241203091036.59898-2-philmd@linaro.org> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Dec 03, 2024 at 10:10:35AM +0100, Philippe Mathieu-Daudé wrote: > When testing with a HVF-only binary, we get: > > 3/12 qemu:func-quick+func-aarch64 / func-aarch64-version ERROR 0.29s exit status 1 > stderr: > Traceback (most recent call last): > File "tests/functional/test_version.py", line 22, in test_qmp_human_info_version > self.vm.launch() > File "machine/machine.py", line 461, in launch > raise VMLaunchFailure( > qemu.machine.machine.VMLaunchFailure: ConnectError: Failed to establish session: EOFError > Exit code: 1 > Command: build/qemu-system-aarch64 -display none -vga none -chardev socket,id=mon,fd=5 -mon chardev=mon,mode=control -machine none -nodefaults > Output: qemu-system-aarch64: No accelerator selected and no default accelerator available > > Explicit the QTest accelerator to be able to run the HMP command. > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/functional/test_version.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/functional/test_version.py b/tests/functional/test_version.py > index 3ab3b67f7e3..d3da796991f 100755 > --- a/tests/functional/test_version.py > +++ b/tests/functional/test_version.py > @@ -18,6 +18,7 @@ class Version(QemuSystemTest): > > def test_qmp_human_info_version(self): > self.set_machine('none') > + self.vm.add_args('-accel', 'qtest') IMHO this is wrong. The functional tests are there to test the real functional behaviour under an actual accelerator not qtest. We have tests/qtests for testing scenarios where we want to only exercise with the qtest accelerator. If QEMU is built with /only/ HVF available and HVF can't be used at runtime, then we should be skipping all functional tests, not degrading them to be hardcoded to use qtest on all platforms. > self.vm.add_args('-nodefaults') > self.vm.launch() > res = self.vm.cmd('human-monitor-command', With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|