Re: [PATCH v2 2/2] platform/x86: x86-android-tablets: Add Vexia EDU ATLA 10 EC battery driver

[Andy Shevchenko <andy.shevchenko@gmail.com>]

On Tue, Dec 03, 2024 at 05:09:57PM +0100, Hans de Goede wrote:
> On 3-Dec-24 1:58 PM, Andy Shevchenko wrote:
> > On Mon, Dec 2, 2024 at 11:48 PM Hans de Goede <hdegoede@redhat.com> wrote:
> >> On 2-Dec-24 7:45 PM, Andy Shevchenko wrote:
> >>> On Mon, Dec 02, 2024 at 08:34:01PM +0200, Ilpo Järvinen wrote:
> >>>> On Sat, 16 Nov 2024, Hans de Goede wrote:

...

> >>>>> +struct atla10_ec_battery_state {
> >>>>> +   u8 status;                      /* Using ACPI Battery spec status bits */
> >>>>> +   u8 capacity;                    /* Percent */
> > 
> > Then an obvious remark based on Hans' reply, why are these internal
> > kernel types and not external ones, i.e. __u8?
> 
> Because this is not a uapi header? 

Hmm... Yes and no. The protocols (on a wire) are kinda external to the kernel
even if they are part of the kernel project as we usually define endianess
there and other things (like packing the data). The same applicable to the SW
protocols to commumicate with FW. But I haven't seen a clear documentation
on these cases and I see examples of all possible combinations of the types.

-- 
With Best Regards,
Andy Shevchenko