Re: [oe-core][PATCH] libsecret: add pam support depending on DISTRO_FEATURES

[Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>]

On Wed, Nov 20, 2024 at 07:35:28PM +0100, Markus Volk wrote:
> pam module has been ported from gnome-keyring to libsecret
> [https://gitlab.gnome.org/GNOME/libsecret/-/commit/9a37dc839a9be1670afeb647d9f82b6ef1cd0893]
> 
> Add a PACKAGECONFIG for pam and enable it if pam is in
> DISTRO_FEATURES
> 
> Add a patch that disables the pam test, because it would require
> pam_wrapper recipe
> 
> [https://gitlab.com/cwrap/pam_wrapper]
> 
> Signed-off-by: Markus Volk <f_l_k@t-online.de>

Hi Markus,

> +Upstream-Status Inappropriate [oe-specific]

Still speaking of this Upstream-Status, I do get some error on the
autobuilder:

ERROR: libsecret-0.21.4-r0 do_patch: QA Issue: Malformed Upstream-Status in patch
/srv/pokybuild/yocto-worker/no-x11/build/meta/recipes-gnome/libsecret/libsecret/0001-pam-disable-tests.patch
Please correct according to https://docs.yoctoproject.org/contributor-guide/recipe-style-guide.html#patch-upstream-status :
Upstream-Status Inappropriate [oe-specific] [patch-status]
ERROR: libsecret-0.21.4-r0 do_patch: Fatal QA errors were found, failing task.

https://valkyrie.yoctoproject.org/#/builders/25/builds/497/steps/11/logs/stdio

Can you check this, please ?

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com