From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 216ACD3B7F6 for ; Mon, 25 Nov 2024 09:36:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tFVW7-0002cJ-Ot; Mon, 25 Nov 2024 04:36:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFVVm-0002XD-5O for qemu-devel@nongnu.org; Mon, 25 Nov 2024 04:36:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFVVk-0003nZ-Kh for qemu-devel@nongnu.org; Mon, 25 Nov 2024 04:36:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732527363; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+fo9oGFY6h96pI9D34rIeXRrEJuVxOrQXSlEVRFeLr8=; b=JpjLHSihSI9deGOr0TpngxDCUYSo98qTlRqsN2wUPsuQJArGk1emKr1f9il4gWhI/rqvHj 6GUIY5PZVj11rDm3+DRIGn0V8sePhQ39XFBnOY5+Pipiv2PMKUot5qgXDfXJJ9UOWbfVGz jDsu9AyP/SqKflhcMs1DYIypxXTLivw= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-FwGysA6XPQucRcEHaZwGOQ-1; Mon, 25 Nov 2024 04:36:01 -0500 X-MC-Unique: FwGysA6XPQucRcEHaZwGOQ-1 X-Mimecast-MFC-AGG-ID: FwGysA6XPQucRcEHaZwGOQ Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C43211953954; Mon, 25 Nov 2024 09:35:58 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.111]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D82B31955F43; Mon, 25 Nov 2024 09:35:54 +0000 (UTC) Date: Mon, 25 Nov 2024 09:35:51 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Kevin Wolf Cc: qemu-block@nongnu.org, peter.maydell@linaro.org, vsementsov@yandex-team.ru, stefanha@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org Subject: Re: [PATCH] tests/avocado/hotplug_blk: Fix addr in device_add command Message-ID: References: <20241122224042.149258-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241122224042.149258-1-kwolf@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Nov 22, 2024 at 11:40:42PM +0100, Kevin Wolf wrote: > pci_devfn properties accept both integer and string values, but > integer 1 and string '1' have different meanings: The integer value > means device 0, function 1 whereas the string value '1' is short for > '1.0' and means device 1, function 0. > > This test wants the string version so that the device actually becomes > visible for the guest. device_add hides the problem because it goes > through QemuOpts, which turns all properties into strings - this is a > QEMU bug that we want to fix, but that cancelled out the bug in this > test. > > Fix the test first so that device_add can be fixed afterwards. > > Signed-off-by: Kevin Wolf > --- > tests/avocado/hotplug_blk.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|