From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexandre Mergnat <amergnat@baylibre.com>
Cc: Mark Brown <broonie@kernel.org>,
Nicolas Belin <nbelin@baylibre.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH v1 1/1] ASoc: mediatek: mt8365: Don't use "proxy" headers
Date: Mon, 25 Nov 2024 13:50:02 +0200 [thread overview]
Message-ID: <Z0RkaqfID9v0age_@smile.fi.intel.com> (raw)
In-Reply-To: <dad2ecb7-e624-49c2-a7d5-0ff53b6a1686@baylibre.com>
On Mon, Nov 25, 2024 at 12:32:13PM +0100, Alexandre Mergnat wrote:
> Hello Andy.
>
> Actually, after test it, "linux/of_gpio.h" isn't needed at all anymore.
>
> That mean all added include in this patch aren't required.
Do you mean the driver doesn't not use types from types.h or dev_*() macros
from dev_printk.h? I don't believe this, sorry.
Basically what you are trying to say is "let's move of_gpio.h implicit
includes to become something else's problem". It's not what this patch
intended to do.
> On 04/11/2024 22:12, Mark Brown wrote:
> > On Mon, Nov 04, 2024 at 09:06:26PM +0200, Andy Shevchenko wrote:
> > > On Thu, Oct 31, 2024 at 12:27:25PM +0200, Andy Shevchenko wrote:
> > > > Update header inclusions to follow IWYU (Include What You Use)
> > > > principle.
> >
> > > Hmm... I think we are waiting for somebody to Ack / review this change?
> >
> > Yes.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-25 11:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 10:27 [PATCH v1 1/1] ASoc: mediatek: mt8365: Don't use "proxy" headers Andy Shevchenko
2024-11-04 19:06 ` Andy Shevchenko
2024-11-04 21:12 ` Mark Brown
2024-11-25 11:32 ` Alexandre Mergnat
2024-11-25 11:50 ` Andy Shevchenko [this message]
2024-11-26 10:29 ` Alexandre Mergnat
2024-11-26 10:37 ` Alexandre Mergnat
2024-11-26 15:23 ` Andy Shevchenko
2024-11-26 15:22 ` Andy Shevchenko
2024-12-02 17:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0RkaqfID9v0age_@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbelin@baylibre.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.